Skip to content

test: fs promises, fixes comment, simplifies test - #27242

Merged
Trott merged 1 commit into
nodejs:masterfrom
dnalborczyk:fs-promises
Jun 2, 2019
Merged

test: fs promises, fixes comment, simplifies test#27242
Trott merged 1 commit into
nodejs:masterfrom
dnalborczyk:fs-promises

Conversation

@dnalborczyk

@dnalborczykdnalborczyk commented Apr 15, 2019

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

fixes some leftover from : #26581

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Apr 15, 2019
BridgeAR
BridgeAR approved these changes Apr 16, 2019
View reviewed changes

@BridgeARBridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a suggestion.

Comment threadtest/parallel/test-fs-promises.js Outdated
ZYSzys
ZYSzys approved these changes Apr 17, 2019
View reviewed changes

@ZYSzysZYSzys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if comments landed.

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 2, 2019
@nodejs-github-bot

nodejs-github-bot commented Jun 2, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23562/

@dnalborczyk@Trott
test: simplify fs promises test
e0c4a9c
Simplify test, fix comment.
PR-URL: nodejs#27242
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott

Trott commented Jun 2, 2019

Copy link
Copy Markdown
Member

Landed in e0c4a9c

@Trott
Trott merged commit e0c4a9c into nodejs:masterJun 2, 2019
targos pushed a commit that referenced this pull request Jun 3, 2019
@dnalborczyk@targos
test: simplify fs promises test
887dd60
Simplify test, fix comment.
PR-URL: #27242
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targostargos mentioned this pull request Jun 3, 2019
Merged
@dnalborczyk
dnalborczyk deleted the fs-promises branch June 5, 2021 02:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@ZYSzysZYSzysZYSzys approved these changes
+1 more reviewer
@shisamashisamashisama approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@dnalborczyk@nodejs-github-bot@Trott@lpinca@BridgeAR@shisama@ZYSzys