Uh oh!
There was an error while loading. Please reload this page.
[v11.x] deps: V8: backport 61f4c22 - #27259
Closed
addaleax wants to merge 1 commit into
Closed
Conversation
The differences to the original patch are the replacement of `i::IsIdentifier...()` with `unicode_cache_.IsIdentifier...()`, because the former is not available on Node.js v11.x, as well as the omitted `no_gc` argument for `GetFlatContent()`. Original commit message: Assume flat string when checking CompileFunctionInContext arguments. R=jkummerow@chromium.org Change-Id: I54c6137a3c6e14d4102188f154aa7216e7414dbc Reviewed-on: https://chromium-review.googlesource.com/c/1388533 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{nodejs#58562} Refs: v8/v8@61f4c22Fixes: nodejs#27256
nodejs-github-bot
commented
Apr 16, 2019
Collaborator
nodejs-github-bot
commented
Apr 16, 2019
Collaborator
addaleax
commented
Apr 16, 2019
MemberAuthor
nodejs-github-bot
commented
Apr 16, 2019
Collaborator
cjihrig
approved these changes
Apr 17, 2019
joyeecheung
approved these changes
Apr 17, 2019
Merged
codebytere
approved these changes
Apr 26, 2019
codebytere pushed a commit
that referenced
this pull request
Apr 29, 2019
The differences to the original patch are the replacement of `i::IsIdentifier...()` with `unicode_cache_.IsIdentifier...()`, because the former is not available on Node.js v11.x, as well as the omitted `no_gc` argument for `GetFlatContent()`. Original commit message: Assume flat string when checking CompileFunctionInContext arguments. R=jkummerow@chromium.org Change-Id: I54c6137a3c6e14d4102188f154aa7216e7414dbc Reviewed-on: https://chromium-review.googlesource.com/c/1388533 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#58562} Refs: v8/v8@61f4c22Fixes: #27256 PR-URL: #27259 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>
codebytere
commented
Apr 29, 2019
Member
Landed in |
richardlau
commented
Oct 7, 2020
Member
Tried to cherry-pick this to v10.x-staging but it fails to compile and would need to be manually backported (if at all). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The differences to the original patch are the replacement of
i::IsIdentifier...()withunicode_cache_.IsIdentifier...(),because the former is not available on Node.js v11.x, as well
as the omitted
no_gcargument forGetFlatContent().Original commit message:
Refs: v8/v8@61f4c22
Fixes: #27256
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes