Uh oh!
There was an error while loading. Please reload this page.
doc: fix comma splice in Assertion Testing doc - #2728
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Trott
commented
Sep 7, 2015
MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/264/ Didn't see an obvious "documentation only" checkbox so went with the full CI. |
cjihrig
commented
Sep 7, 2015
Contributor
LGTM |
1 similar comment
targos
commented
Sep 7, 2015
Member
LGTM |
jbergstroem
commented
Sep 8, 2015
Member
LGTM @Trott afaik the setting to merge docs only doesn't exist for node-test-pr, only the merge counterpart. Perhaps worth adding. |
Trott added a commit
that referenced
this pull request
Sep 8, 2015
This fixes a minor typographical error in the Assertion Testing doc. PR-URL: #2728 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Trott
commented
Sep 8, 2015
MemberAuthor
Landed in 8f87169 |
Trott added a commit
that referenced
this pull request
Sep 8, 2015
This fixes a minor typographical error in the Assertion Testing doc. PR-URL: #2728 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Trott added a commit
that referenced
this pull request
Sep 12, 2015
This fixes a minor typographical error in the Assertion Testing doc. PR-URL: #2728 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor typo fix. /cc @nodejs/documentation