Skip to content

build: improve embedded code-cache detection - #27311

Merged
refack merged 1 commit into
nodejs:masterfrom
refack:fix-config-code-cache-bug
Apr 22, 2019
Merged

build: improve embedded code-cache detection#27311
refack merged 1 commit into
nodejs:masterfrom
refack:fix-config-code-cache-bug

Conversation

@refack

@refackrefack commented Apr 19, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Follow up to #27308

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-botnodejs-github-bot added the build Issues and PRs related to build files or the CI. label Apr 19, 2019
@refack
refack requested a review from joyeecheungApril 19, 2019 13:44
@refackrefack mentioned this pull request Apr 19, 2019
Closed
2 tasks
joyeecheung
joyeecheung reviewed Apr 19, 2019
View reviewed changes
Comment threadtest/sequential/test-cpu-prof.js Outdated
@refack
refackforce-pushed the fix-config-code-cache-bug branch from 0606363 to 98deba3CompareApril 19, 2019 21:59
@nodejs-github-bot

nodejs-github-bot commented Apr 19, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22570/

@refack

refack commented Apr 19, 2019

Copy link
Copy Markdown
ContributorAuthor

Added process.features.code_cache field based on compile time constant, and not build configuration.

@refackrefack added the process Issues and PRs related to the process subsystem. label Apr 19, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
joyeecheung
joyeecheung reviewed Apr 20, 2019
View reviewed changes
Comment threadlib/internal/bootstrap/node.js Outdated
@refackrefack self-assigned this Apr 20, 2019
@refack

refack commented Apr 20, 2019

Copy link
Copy Markdown
ContributorAuthor

Ping @nodejs/build-files @nodejs/process

@refack
refackforce-pushed the fix-config-code-cache-bug branch from f0b5677 to cbf534cCompareApril 21, 2019 13:35
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 21, 2019
BridgeAR
BridgeAR reviewed Apr 21, 2019
View reviewed changes
Comment threadconfigure.py Outdated
Comment threadlib/internal/bootstrap/node.js Outdated
@BridgeARBridgeAR removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 21, 2019
@refack
refackforce-pushed the fix-config-code-cache-bug branch from cbf534c to 4d81c09CompareApril 21, 2019 19:39
@nodejsnodejs deleted a comment from nodejs-github-botApr 21, 2019
@nodejs-github-bot

nodejs-github-bot commented Apr 21, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22602/

@refack
build: improve embedded code-cache detection
5aaf666
PR-URL: nodejs#27311
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@refack
refackforce-pushed the fix-config-code-cache-bug branch from 4d81c09 to 5aaf666CompareApril 22, 2019 18:49
@refack
refack merged commit 5aaf666 into nodejs:masterApr 22, 2019
@refack
refack deleted the fix-config-code-cache-bug branch April 22, 2019 18:51
@refackrefack removed their assignment Apr 22, 2019
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Sep 12, 2024
Merged
Merged
nodejs-github-bot pushed a commit that referenced this pull request Sep 17, 2024
@aduh95
doc: fix history of process.features
421977c
PR-URL: #54982
Refs: aa0308d
Refs: 9010f5f
Refs: 52a40e0
Refs: b3ef289
Refs: #2564
Refs: #25819
Refs: #27311
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
targos pushed a commit that referenced this pull request Oct 4, 2024
@aduh95@targos
doc: fix history of process.features
f2d74a2
PR-URL: #54982
Refs: aa0308d
Refs: 9010f5f
Refs: 52a40e0
Refs: b3ef289
Refs: #2564
Refs: #25819
Refs: #27311
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Feb 10, 2025
@aduh95@marco-ippolito
doc: fix history of process.features
910c30f
PR-URL: nodejs#54982
Refs: nodejs@aa0308d
Refs: nodejs@9010f5f
Refs: nodejs@52a40e0
Refs: nodejs@b3ef289
Refs: nodejs#2564
Refs: nodejs#25819
Refs: nodejs#27311
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
marco-ippolito pushed a commit that referenced this pull request Feb 10, 2025
@aduh95@marco-ippolito
doc: fix history of process.features
697a392
PR-URL: #54982
Backport-PR-URL: #56948
Refs: aa0308d
Refs: 9010f5f
Refs: 52a40e0
Refs: b3ef289
Refs: #2564
Refs: #25819
Refs: #27311
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
PR-URL: #54897
Refs: #54295
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheungjoyeecheungjoyeecheung approved these changes
@BridgeARBridgeARBridgeAR left review comments
@richardlaurichardlaurichardlau approved these changes
+1 more reviewer
@mihalskiymihalskiymihalskiy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.processIssues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@refack@nodejs-github-bot@joyeecheung@richardlau@BridgeAR@mihalskiy