Skip to content

test: fix ineffective error tests - #27333

Closed
shisama wants to merge 3 commits into
nodejs:masterfrom
shisama:test-ineffective-errors
Closed

test: fix ineffective error tests#27333
shisama wants to merge 3 commits into
nodejs:masterfrom
shisama:test-ineffective-errors

Conversation

@shisama

@shisamashisama commented Apr 21, 2019

Copy link
Copy Markdown
Contributor

Fix tests whether errors are thrown correctly
because they are successful when error doesn't get thrown.

fix#26385

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Apr 21, 2019

Copy link
Copy Markdown
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3316

@nodejs-github-botnodejs-github-bot added addons Issues and PRs related to native addons. test Issues and PRs related to the tests. labels Apr 21, 2019
Masashi Hirano
test: fix ineffective error tests
52fb259
Fix tests whether errors are thrown correctly
because they are successful when error doesn't get thrown.
@shisama
shisamaforce-pushed the test-ineffective-errors branch from aa46727 to 52fb259CompareApril 21, 2019 14:52
BridgeAR
BridgeAR approved these changes Apr 21, 2019
View reviewed changes

@BridgeARBridgeAR left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM while I would prefer to use assert.throws(fn, errorFunction) (or assert.rejects() for promises) instead of try / catch in combination with threw or assert.fail(). That way each test is nicely encapsulated.

@shisama
shisamaforce-pushed the test-ineffective-errors branch 3 times, most recently from 3d63790 to c862bd1CompareApril 21, 2019 15:51
@shisama
shisamaforce-pushed the test-ineffective-errors branch from c862bd1 to 823bfbeCompareApril 21, 2019 16:45
@shisama

shisama commented Apr 21, 2019

Copy link
Copy Markdown
ContributorAuthor

@BridgeAR Thank you for your review. I fix this PR to use assert.throws or assert.rejects instead of try / catch. Would you please review this again?

BridgeAR
BridgeAR reviewed Apr 21, 2019
View reviewed changes
Comment threadtest/parallel/test-assert.js
Comment threadtest/parallel/test-vm-codegen.js Outdated
Comment threadtest/parallel/test-assert.js
BridgeAR
BridgeAR approved these changes Apr 23, 2019
View reviewed changes

@BridgeARBridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM. Thanks for following up on the suggestions.

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 23, 2019
@nodejs-github-bot

nodejs-github-bot commented Apr 23, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22650/

@danbev

danbev commented Apr 24, 2019

Copy link
Copy Markdown
Contributor

Landed in fb3f600.

@danbevdanbev closed this Apr 24, 2019
danbev pushed a commit that referenced this pull request Apr 24, 2019
Masashi Hirano@danbev
test: fix ineffective error tests
fb3f600
Fix tests whether errors are thrown correctly
because they are successful when error doesn't get thrown.
PR-URL: #27333Fixes: #26385
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@shisama
shisama deleted the test-ineffective-errors branch April 24, 2019 12:43
targos pushed a commit that referenced this pull request Apr 27, 2019
Masashi Hirano@targos
test: fix ineffective error tests
f0b2992
Fix tests whether errors are thrown correctly
because they are successful when error doesn't get thrown.
PR-URL: #27333Fixes: #26385
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targostargos mentioned this pull request Apr 27, 2019
Merged
@ChALkeR

ChALkeR commented May 22, 2019

Copy link
Copy Markdown
Member

Thanks for doing this! =)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

addonsIssues and PRs related to native addons.author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tests: review and fix ineffective error tests

6 participants

@shisama@nodejs-github-bot@danbev@ChALkeR@lpinca@BridgeAR