Uh oh!
There was an error while loading. Please reload this page.
doc: simplify Collaborator pre-nomination text - #27348
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Split one very long sentence into three shorter sentences.
nodejs-github-bot
commented
Apr 22, 2019
Collaborator
vsemozhetbyt
approved these changes
Apr 22, 2019
vsemozhetbyt
commented
Apr 22, 2019
Contributor
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
Fishrock123
approved these changes
Apr 22, 2019
cjihrig
approved these changes
Apr 22, 2019
BridgeAR
approved these changes
Apr 22, 2019
apapirovski
approved these changes
Apr 22, 2019
danbev
commented
Apr 23, 2019
Contributor
Landed in 8594211. |
danbev pushed a commit
that referenced
this pull request
Apr 23, 2019
Split one very long sentence into three shorter sentences. PR-URL: #27348 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
targos pushed a commit
that referenced
this pull request
Apr 27, 2019
Split one very long sentence into three shorter sentences. PR-URL: #27348 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split one very long sentence into three shorter sentences.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes