Uh oh!
There was an error while loading. Please reload this page.
benchmark: fix http bench-parser.js - #27359
Merged
Merged
Conversation
nodejs-github-bot
commented
Apr 23, 2019
Collaborator
3 tasks
Contributor
CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/6412/ (filed with a different test as expected) |
refack
commented
Apr 23, 2019
Contributor
We should fast-track this when it passes CI testing. |
refack
approved these changes
Apr 23, 2019
benjamingr
approved these changes
Apr 23, 2019
Merged
The internal HTTParser `reinitialize()` function was removed in ece5073 and replaced with an `initialize()` function. This broke benchmark/http/bench-parser.js. This change updates the benchmark so that it runs again. PR-URL: nodejs#27359 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
refack
commented
Apr 23, 2019
Contributor
Landed in 62c7b2e |
targos pushed a commit
that referenced
this pull request
Apr 27, 2019
The internal HTTParser `reinitialize()` function was removed in ece5073 and replaced with an `initialize()` function. This broke benchmark/http/bench-parser.js. This change updates the benchmark so that it runs again. PR-URL: #27359 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The internal HTTParser
reinitialize()function was removed inece5073 and replaced with an
initialize()function. This brokebenchmark/http/bench-parser.js. This change updates the benchmark so
that it runs again.
/ping @nodejs/async_hooks @Drieger to make sure this is the correct change here.... If so, I would like to fast-track because this issue breaks the nightly benchmark tests on Jenkins.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes