report: print common items first for readability

[gengjiawen]

cc @richardlau

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• documentation is changed or added
• commit message follows commit guidelines

[richardlau]

Can you update the timer example in the docs too? Otherwise LGTM.

[gengjiawen]

Can you update the timer example in the docs too? Otherwise LGTM.

I am not sure which part. Can you post a link or snippet ? Thanks.

[richardlau]

Can you update the timer example in the docs too? Otherwise LGTM.

I am not sure which part. Can you post a link or snippet ? Thanks.

GitHub makes it hard to link to snippets in markdown docs but the timer handle info around L193.

[gengjiawen]

GitHub makes it hard to link to snippets in markdown docs but the timer handle info around L193.

I see. I will try to fix it after I watched Avengers: Endgame tonight 😎.

[gengjiawen]

@richardlau Fixed.

[jasnell]

Hmm... are there no tests that are verifying the actual output here? I know there's quite a bit that's non-deterministic but there should at least be some validation in the test. Changing the order of these these should break at least something in the tests :-)

[richardlau]

Hmm... are there no tests that are verifying the actual output here? I know there's quite a bit that's non-deterministic but there should at least be some validation in the test. Changing the order of these these should break at least something in the tests :-)

We have a test that verifies the libuv handle information (test/report/test-report-uv-handles.js) but it is not affected by reordering as it uses JSON.parse() to parse the report and tests the parsed data.

[jasnell]

Hmm... ok, I think that's definitely something we can improve. A basic message type test that checks the unparsed output would be worthwhile

[gengjiawen]

Hmm... ok, I think that's definitely something we can improve. A basic message type test that checks the unparsed output would be worthwhile

Is there any example I can reference for output key sort ?

[gengjiawen]

Now we have nested structure like this, looks like more hard to match 😭

{
"localEndpoint": {
"host": "0.0.0.0",
"port": 56288
},
"remoteEndpoint": null,
"sendBufferSize": 9216,
"recvBufferSize": 786896,
"fd": 33,
"type": "udp",
"is_active": true,
"is_referenced": true,
"address": "0x0000000103507bf0"
}
}

[gengjiawen]

Will try something like this in test-report-uv-handles

{constget_libuv=/"libuv":\s\[([\s\S]*?)\]/gm;constget_handle_inner=/{([\s\S]*?),*?}/gm;constlibuv_handles_str=get_libuv.exec(stdout)[1];constlibuv_handles_array=libuv_handles_str.match(get_handle_inner);libuv_handles_array.map(i=>{// exclude nested structureif(i.includes('type')){consthandle_keys=i.match(/(".*"):/gm);assert(handle_keys[0],'type');assert(handle_keys[1],'is_active');}});}

[gengjiawen]

Not know why this test keep failed on my win10, so just let's travis run the tests ...

Debugger attached.assert.js:87 throw new AssertionError(obj); ^AssertionError [ERR_ASSERTION]: Process exited unexpectedly with code1 at ChildProcess.<anonymous> (D:\Developer\node\test\report\test-report-uv-handles.js:88:12) at ChildProcess.<anonymous> (D:\Developer\node\test\common\index.js:373:15) at ChildProcess.emit (events.js:194:13) at Process.ChildProcess._handle.onexit (internal/child_process.js:254:12)Waiting for the debugger to disconnect..

[gengjiawen]

@richardlau@jasnell I add related test and CI is green, can you review this again ? thanks.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22747/

[targos]

Landed in 38f3526