Skip to content

Update certdata nss 3.43 - #27374

Closed
sam-github wants to merge 2 commits into
nodejs:masterfrom
sam-github:update-certdata-nss-3.43
Closed

Update certdata nss 3.43#27374
sam-github wants to merge 2 commits into
nodejs:masterfrom
sam-github:update-certdata-nss-3.43

Conversation

@sam-github

@sam-githubsam-github commented Apr 23, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

As described in https://github.com/nodejs/node/blob/master/doc/guides/updating-root-certs.md

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@sam-github
tools: update certdata.txt
f5fa096
This is the certdata.txt[0] from NSS 3.43, released on 2019-03-15.
This is the version of NSS that will ship in Firefox 67 on
2019-03-19.
[0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_43_RTM/lib/ckfw/builtins/certdata.txt
@sam-github
crypto: update root certificates
40c5cc1
Update the list of root certificates in src/node_root_certs.h with
tools/mk-ca-bundle.pl.
Certificates added:
- emSign Root CA - G1
- emSign ECC Root CA - G3
- emSign Root CA - C1
- emSign ECC Root CA - C3
- Hongkong Post Root CA 3
@nodejs-github-bot

nodejs-github-bot commented Apr 23, 2019

Copy link
Copy Markdown
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3345

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Apr 23, 2019
bnoordhuis
bnoordhuis approved these changes Apr 23, 2019
View reviewed changes

@bnoordhuisbnoordhuis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

BridgeAR
BridgeAR approved these changes Apr 24, 2019
View reviewed changes

@BridgeARBridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 24, 2019
@nodejs-github-bot

nodejs-github-bot commented Apr 24, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22679/

@sam-github

sam-github commented Apr 25, 2019

Copy link
Copy Markdown
ContributorAuthor

Landed in c80c414...5ab65cf

@sam-github
sam-github deleted the update-certdata-nss-3.43 branch April 25, 2019 23:17
sam-github added a commit that referenced this pull request Apr 25, 2019
@sam-github
tools: update certdata.txt
a016dc9
This is the certdata.txt[0] from NSS 3.43, released on 2019-03-15.
This is the version of NSS that will ship in Firefox 67 on
2019-03-19.
[0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_43_RTM/lib/ckfw/builtins/certdata.txt
PR-URL: #27374
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
sam-github added a commit that referenced this pull request Apr 25, 2019
@sam-github
crypto: update root certificates
5ab65cf
Update the list of root certificates in src/node_root_certs.h with
tools/mk-ca-bundle.pl.
Certificates added:
- emSign Root CA - G1
- emSign ECC Root CA - G3
- emSign Root CA - C1
- emSign ECC Root CA - C3
- Hongkong Post Root CA 3
PR-URL: #27374
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Apr 27, 2019
@sam-github@targos
tools: update certdata.txt
dcbe5b9
This is the certdata.txt[0] from NSS 3.43, released on 2019-03-15.
This is the version of NSS that will ship in Firefox 67 on
2019-03-19.
[0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_43_RTM/lib/ckfw/builtins/certdata.txt
PR-URL: #27374
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Apr 27, 2019
@sam-github@targos
crypto: update root certificates
b21b28f
Update the list of root certificates in src/node_root_certs.h with
tools/mk-ca-bundle.pl.
Certificates added:
- emSign Root CA - G1
- emSign ECC Root CA - G3
- emSign Root CA - C1
- emSign ECC Root CA - C3
- Hongkong Post Root CA 3
PR-URL: #27374
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targostargos mentioned this pull request Apr 27, 2019
Merged
bnoordhuis pushed a commit to bnoordhuis/io.js that referenced this pull request Aug 15, 2019
@sam-github@bnoordhuis
tools: update certdata.txt
2421e96
This is the certdata.txt[0] from NSS 3.43, released on 2019-03-15.
This is the version of NSS that will ship in Firefox 67 on
2019-03-19.
[0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_43_RTM/lib/ckfw/builtins/certdata.txt
PR-URL: nodejs#27374
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
bnoordhuis pushed a commit to bnoordhuis/io.js that referenced this pull request Aug 15, 2019
@sam-github@bnoordhuis
crypto: update root certificates
9e62956
Update the list of root certificates in src/node_root_certs.h with
tools/mk-ca-bundle.pl.
Certificates added:
- emSign Root CA - G1
- emSign ECC Root CA - G3
- emSign Root CA - C1
- emSign ECC Root CA - C3
- Hongkong Post Root CA 3
PR-URL: nodejs#27374
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs pushed a commit that referenced this pull request Sep 19, 2019
@sam-github@BethGriggs
tools: update certdata.txt
4fbadf6
This is the certdata.txt[0] from NSS 3.43, released on 2019-03-15.
This is the version of NSS that will ship in Firefox 67 on
2019-03-19.
[0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_43_RTM/lib/ckfw/builtins/certdata.txt
PR-URL: #27374
Backport-PR-URL: #29137
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs pushed a commit that referenced this pull request Sep 19, 2019
@sam-github@BethGriggs
crypto: update root certificates
347fcd3
Update the list of root certificates in src/node_root_certs.h with
tools/mk-ca-bundle.pl.
Certificates added:
- emSign Root CA - G1
- emSign ECC Root CA - G3
- emSign Root CA - C1
- emSign ECC Root CA - C3
- Hongkong Post Root CA 3
PR-URL: #27374
Backport-PR-URL: #29137
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggsBethGriggs mentioned this pull request Sep 19, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuisbnoordhuisbnoordhuis approved these changes
@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sam-github@nodejs-github-bot@bnoordhuis@BridgeAR