Skip to content

test: remove flaky designation for test-tls-sni-option - #27425

Closed
lpinca wants to merge 1 commit into
nodejs:masterfrom
lpinca:deflake/test-tls-sni-option
Closed

test: remove flaky designation for test-tls-sni-option#27425
lpinca wants to merge 1 commit into
nodejs:masterfrom
lpinca:deflake/test-tls-sni-option

Conversation

@lpinca

Copy link
Copy Markdown
Member

Refs: #27300

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Apr 26, 2019
@ZYSzysZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 27, 2019
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@Trott

Copy link
Copy Markdown
Member

Landed in 351a252

@TrottTrott closed this Apr 30, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 30, 2019
Refs: nodejs#27300
PR-URL: nodejs#27425
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@lpinca
lpinca deleted the deflake/test-tls-sni-option branch May 1, 2019 05:54
targos pushed a commit that referenced this pull request May 4, 2019
Refs: #27300
PR-URL: #27425
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targostargos mentioned this pull request May 6, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@lpinca@nodejs-github-bot@Trott@cjihrig@ZYSzys