Uh oh!
There was an error while loading. Please reload this page.
test: add mustCall to test-net-after-close test - #27459
Closed
xuqinggang wants to merge 1 commit into
Closed
Conversation
ZYSzys
approved these changes
Apr 28, 2019
starkwang
approved these changes
Apr 28, 2019
yorkie
approved these changes
Apr 28, 2019
gireeshpunathil
approved these changes
Apr 28, 2019
nodejs-github-bot
commented
Apr 28, 2019
Collaborator
gireeshpunathil
commented
Apr 28, 2019
Member
please leave 👍 to fast track |
cjihrig
approved these changes
Apr 28, 2019
cjihrig
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but the mustCall() isn't necessary.
nodejs-github-bot
commented
Apr 28, 2019
Collaborator
antsmartian
approved these changes
Apr 29, 2019
Trott
approved these changes
Apr 29, 2019
Trott
commented
Apr 29, 2019
Member
Landed in 095bd56 |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 29, 2019
PR-URL: nodejs#27459 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott
commented
Apr 29, 2019
Member
Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
targos pushed a commit
that referenced
this pull request
Apr 30, 2019
PR-URL: #27459 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This was referenced May 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test: add mustCall to test-net-after-close test