Uh oh!
There was an error while loading. Please reload this page.
Revert "test: skip test-cpu-prof in debug builds with code cache" - #27469
Closed
addaleax wants to merge 1 commit into
Closed
Revert "test: skip test-cpu-prof in debug builds with code cache"#27469addaleax wants to merge 1 commit into
addaleax wants to merge 1 commit into
Conversation
Skipping the test is not needed now that the underlying cause has been addressed in V8. This reverts commit b66f01d. Refs: nodejs#27423
nodejs-github-bot
commented
Apr 29, 2019
Collaborator
nodejs-github-bot
commented
Apr 29, 2019
Collaborator
gengjiawen
approved these changes
Apr 29, 2019
Trott
approved these changes
Apr 29, 2019
joyeecheung
approved these changes
Apr 29, 2019
cjihrig
approved these changes
Apr 29, 2019
Trott
commented
May 1, 2019
Member
Landed in 5f68489 |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
May 1, 2019
Skipping the test is not needed now that the underlying cause has been addressed in V8. This reverts commit b66f01d. Refs: nodejs#27423 PR-URL: nodejs#27469 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This was referenced May 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skipping the test is not needed now that the underlying cause
has been addressed in V8.
This reverts commit b66f01d.
Refs: #27423
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes