Uh oh!
There was an error while loading. Please reload this page.
src: refactor V8ProfilerConnection to be more reusable - #27475
Closed
joyeecheung wants to merge 3 commits into
Closed
src: refactor V8ProfilerConnection to be more reusable#27475joyeecheung wants to merge 3 commits into
joyeecheung wants to merge 3 commits into
Conversation
- Process and store --cpu-prof-dir and --cpu-prof-name during Environment creation - Start profilers in on `profiler::StartProfilers()`
Now the subclasses only need to override methods to - Get the profile node from the profiler response message object - Return the directory and file path And the V8ProfilerConnection() would handle the rest of profile serialization and message parsing. This makes it easier to add other types of profiles in the future.
nodejs-github-bot
commented
Apr 29, 2019
Collaborator
nodejs-github-bot
commented
Apr 29, 2019
Collaborator
nodejs-github-bot
commented
Apr 29, 2019
Collaborator
bnoordhuis
approved these changes
Apr 30, 2019
bnoordhuis
left a comment
Member
There was a problem hiding this comment.
The first commit log has an extraneous "on" in "Start profilers in on profiler::StartProfilers()".
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
May 1, 2019
Collaborator
MemberAuthor
Fixed punctuation of comments and left some TODOs for @bnoordhuis 's reviews.
Oops, I meant |
nodejs-github-bot
commented
May 1, 2019
Collaborator
MemberAuthor
Landed in 6f02f15...58ba952 with the comment about |
joyeecheung added a commit
that referenced
this pull request
May 2, 2019
Now the subclasses only need to override methods to - Get the profile node from the profiler response message object - Return the directory and file path And the V8ProfilerConnection() would handle the rest of profile serialization and message parsing. This makes it easier to add other types of profiles in the future. PR-URL: #27475 Refs: #27421 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
targos pushed a commit
that referenced
this pull request
May 4, 2019
Now the subclasses only need to override methods to - Get the profile node from the profiler response message object - Return the directory and file path And the V8ProfilerConnection() would handle the rest of profile serialization and message parsing. This makes it easier to add other types of profiles in the future. PR-URL: #27475 Refs: #27421 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
This was referenced May 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src: refactor profile initialization
Environment creation
profiler::StartProfilers()src: refactor V8ProfilerConnection to be more reusable
Now the subclasses only need to override methods to
And the V8ProfilerConnection() would handle the rest of profile
serialization and message parsing. This makes it easier to
add other types of profiles in the future.
Refs: #27421
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes