Uh oh!
There was an error while loading. Please reload this page.
tools: add Release and Debug symlinks to .gitignore - #27484
Closed
Flarna wants to merge 2 commits into
Closed
Conversation
Seems at least some windows versions interpret symlinks not as folders therefore .gitignore needs some extra entries.
refack
commented
Apr 29, 2019
Contributor
It seems like it might be right, but probably should come instead of the lines above it (the ones that doesn't end with |
refack
commented
Apr 29, 2019
Contributor
P.S. @Flarna could you elaborate on your set up (Windows version? Git version? are you using git bash?) |
refack
approved these changes
Apr 29, 2019
Flarna
commented
Apr 29, 2019
MemberAuthor
I use
|
refack
commented
Apr 29, 2019
Contributor
Strange, it's quite slimier to mine, except I'm on the skip ahead so I'm on build 18885 (a.k.a post-1903 / 20H1)... |
Flarna
commented
Apr 29, 2019
MemberAuthor
Maybe I enabled some debug setting or so to allow NTFS symlinks some time ago; but if I did I can't remember which one. |
addaleax
approved these changes
Apr 29, 2019
Trott
approved these changes
Apr 29, 2019
BridgeAR
approved these changes
Apr 30, 2019
nodejs-github-bot
commented
May 2, 2019
Collaborator
Trott
commented
May 2, 2019
Member
Landed in ee3b4fd |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
May 2, 2019
Seems at least some windows versions interpret symlinks not as folders therefore .gitignore needs some extra entries. PR-URL: nodejs#27484 Refs: nodejs#27149 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit
that referenced
this pull request
May 4, 2019
Seems at least some windows versions interpret symlinks not as folders therefore .gitignore needs some extra entries. PR-URL: #27484 Refs: #27149 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This was referenced May 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems at least some windows versions interpret symlinks not as folders
therefore .gitignore needs some extra entries.
@refack I think this is related to your PR
Refs: #27149
Checklist