Uh oh!
There was an error while loading. Please reload this page.
test: vm module error thrown when breakOnSigint is not a boolean evaluate() - #27503
Closed
rpgeeganage wants to merge 2 commits into
Closed
test: vm module error thrown when breakOnSigint is not a boolean evaluate()#27503rpgeeganage wants to merge 2 commits into
rpgeeganage wants to merge 2 commits into
Conversation
addaleax
approved these changes
May 1, 2019
nodejs-github-bot
commented
May 1, 2019
Collaborator
Trott
reviewed
May 2, 2019
Uh oh!
There was an error while loading. Please reload this page.
Trott
approved these changes
May 2, 2019
nodejs-github-bot
commented
May 3, 2019
Collaborator
nodejs-github-bot
commented
May 3, 2019
Collaborator
ZYSzys
approved these changes
May 4, 2019
trivikr
approved these changes
May 6, 2019
rpgeeganage
commented
May 6, 2019
ContributorAuthor
@trivikr , thanks for approving the PR. |
trivikr
commented
May 6, 2019
Member
@rpgeeganage Thank you! I'm happy that the video was helpful 😄 |
ZYSzys
commented
May 11, 2019
Member
Landed in 8b78fbd 🎉 |
ZYSzys pushed a commit
that referenced
this pull request
May 11, 2019
PR-URL: #27503 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit
that referenced
this pull request
May 13, 2019
PR-URL: #27503 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This unit test is to assert the error thrown when
none booleanvalue passed asbreakOnSigintattribute to theevaluate()function.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes