Skip to content

assert: remove deprecated assert.fail() functionality - #27526

Closed
BridgeAR wants to merge 2 commits into
nodejs:masterfrom
BridgeAR:remove-deprecated-assert-fail
Closed

assert: remove deprecated assert.fail() functionality#27526
BridgeAR wants to merge 2 commits into
nodejs:masterfrom
BridgeAR:remove-deprecated-assert-fail

Conversation

@BridgeAR

@BridgeARBridgeAR commented May 1, 2019

Copy link
Copy Markdown
Member

This removes the assert.fail() signature with more than one argument.

It is runtime deprecated since v10 and even if the old signature is continued to be used, it'll work similar to before: it will fail but it'll have a different error message.

This should land after #27525 to reduce conflicts backporting the other PR.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR
assert: remove deprecated assert.fail() functionality
05ae52e
This removes the `assert.fail()` signature with more than one argument.
@BridgeARBridgeAR added the semver-major PRs that contain breaking changes and should be released in the next major version. label May 1, 2019
@nodejs-github-bot

nodejs-github-bot commented May 1, 2019

Copy link
Copy Markdown
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3422

@nodejs-github-botnodejs-github-bot added the assert Issues and PRs related to the assert subsystem. label May 1, 2019
@Trott

Trott commented May 2, 2019

Copy link
Copy Markdown
Member

Very interested in CITGM results for this. As you point out, things will still fail, just with a different error message....

benjamingr
benjamingr approved these changes May 2, 2019
View reviewed changes

@benjamingrbenjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already runtime deprecated with a warning and I don't think anyone has complained thus far - so while there isn't a huge motivation to remove this in terms of maintenance cost - if this failed CITGMs it would have likely already happened in the runtime deprecation duration.

@BridgeAR

BridgeAR commented May 2, 2019

Copy link
Copy Markdown
MemberAuthor

CITGM https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1843/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 2, 2019
@nodejs-github-bot

nodejs-github-bot commented May 2, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22896/

@nodejs-github-bot

nodejs-github-bot commented May 2, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22903/

@Trott

Trott commented May 3, 2019

Copy link
Copy Markdown
Member

(Gzemnid might not be a bad idea here too.)

Trott
Trott approved these changes May 3, 2019
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentatively LGTM if CITGM and/or gzemnid queries don't turn up anything too alarming.

@Trott

Trott commented May 3, 2019

Copy link
Copy Markdown
Member

(Needs at least one more @nodejs/tsc approval.)

@nodejs-github-bot

nodejs-github-bot commented May 3, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22920/

@BridgeAR

BridgeAR commented May 3, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

I get a lot of hits checking gzemnid but there are also quite a few false positives. The main problem with these is that are used as this code part should not be reached. Thus the deprecation warning is never triggered and does not really work in this case.

It would be nice if anyone would help looking for false positives to reduce the list below.

grep -aE "assert\.fail\([^,)]+,"
// Actual failures
2496464	ramda-fantasy-0.8.0.tgz/test/future.test.js:19: assert.fail(null, e1, 'Futures not equal: f1 failed, f2 did not', '===');
2496464	ramda-fantasy-0.8.0.tgz/test/future.test.js:26: assert.fail(null, v1, 'Futures not equal: f1 succeeded, f2 did not', '===');
1982872	bunyan-1.8.12.tgz/lib/bunyan.js:1438: assert.fail(format('invalid period scope: "%s"', this.periodScope));
954373	xpath-0.0.27.tgz/test.js:209: assert.fail(null, null, 'evaluate() should throw exception');
634679	ssh2-0.8.2.tgz/test/test-client-server.js:1741: assert.fail(null, null, makeMsg('Unexpected banner'));
634679	ssh2-0.8.2.tgz/test/test-client-server.js:1783: assert.fail(null, null, makeMsg('Unexpected greeting'));
175087	sanitize-html-react-1.13.0.tgz/test/test.js:189: assert.fail('p, a, br', frame.tag);
80611	fast-stats-0.0.5.tgz/tests/t3.js:129: default: assert.fail(e.bucket, "", "", "Unexpected bucket");
80611	fast-stats-0.0.5.tgz/tests/t4.js:37: default: assert.fail(e.bucket, "", "", "Unexpected bucket");
71045	metrics-0.1.21.tgz/test/unit/csv_reporter.js:84: assert.fail(false, false, "File " +f + " does not exist!");
71045	metrics-0.1.21.tgz/test/unit/graphite_reporter.js:85: assert.fail(false, false, err);
59672	datamaps-0.5.9.tgz/src/js/components/topojson/test/assert.js:7: assert.fail(actual, expected, message || "expected {actual} to be in within *" + delta + "* of {expected}", null, assert.inDelta);
54131	pipeworks-1.3.1.tgz/test/pipeworks_test.js:149: assert.fail(context.number, 1, 'Check called twice on same number.');
45434	lint-1.1.2.tgz/lib/assert/extension.js:14: assert.fail(errorCount, 0, message || "LINT validation returned {actual} error(s)", "===", assert.validateLint);
45434	lint-1.1.2.tgz/lib/assert/extension.js:28: assert.fail(errorCount, 0, message || "LINT validation returned {actual} error(s)", "===", assert.validateLintFile);
// Only outdated documentation
98505	unassert-1.5.1.tgz/lib/default-options.js:16: 'assert.fail(actual, expected, message, operator)', // Newer version are fixed 50710	vows-0.8.2.tgz/lib/assert/macros.js:22: assert.fail(actual, expected, message || "cannot compare {actual} with {expected} \u00B1 NaN");
50710	vows-0.8.2.tgz/lib/assert/macros.js:24: assert.fail(actual, expected, message || "expected {expected} \u00B1"+ eps +", but was {actual}");
50710	vows-0.8.2.tgz/lib/assert/macros.js:38: assert.fail(actual, expected, message || "expected {actual} to match {expected}", "match", assert.match);
50710	vows-0.8.2.tgz/lib/assert/macros.js:46: assert.fail(actual, true, message || "expected {expected}, got {actual}", "===", assert.isTrue);
50710	vows-0.8.2.tgz/lib/assert/macros.js:52: assert.fail(actual, false, message || "expected {expected}, got {actual}", "===", assert.isFalse);
50710	vows-0.8.2.tgz/lib/assert/macros.js:58: assert.fail(actual, 0, message || "expected {expected}, got {actual}", "===", assert.isZero);
50710	vows-0.8.2.tgz/lib/assert/macros.js:64: assert.fail(actual, 0, message || "expected non-zero value, got {actual}", "===", assert.isNotZero);
50710	vows-0.8.2.tgz/lib/assert/macros.js:71: assert.fail(actual, expected, message || "expected {actual} to be greater than {expected}", ">", assert.greater);
50710	vows-0.8.2.tgz/lib/assert/macros.js:77: assert.fail(actual, expected, message || "expected {actual} to be lesser than {expected}", "<", assert.lesser);
50710	vows-0.8.2.tgz/lib/assert/macros.js:86: assert.fail(actual, expected, message || "expected {actual} to be in within *" + delta.toString() + "* of {expected}", null, assert.inDelta);
50710	vows-0.8.2.tgz/lib/assert/macros.js:103: assert.fail(actual, expected, message || "expected {actual} to include {expected}", "include", assert.include);
50710	vows-0.8.2.tgz/lib/assert/macros.js:118: assert.fail(actual, expected, message || "expected {actual} not to include {expected}", "include", assert.notInclude);
50710	vows-0.8.2.tgz/lib/assert/macros.js:129: assert.fail(actual, expected, message || "expected {actual} to include {expected}", "include", assert.deepInclude);
50710	vows-0.8.2.tgz/lib/assert/macros.js:140: assert.fail(actual, 0, message || "expected {actual} to be empty", "length", assert.isEmpty);
50710	vows-0.8.2.tgz/lib/assert/macros.js:146: assert.fail(actual, 0, message || "expected {actual} to be not empty", "length", assert.isNotEmpty);
50710	vows-0.8.2.tgz/lib/assert/macros.js:154: assert.fail(actual, expected, message || "expected {actual} to have {expected} element(s)", "length", assert.length);
50710	vows-0.8.2.tgz/lib/assert/macros.js:172: assert.fail(actual, 'number', message || "expected {actual} to be of type {expected}", "isNaN", assert.isNumber);
50710	vows-0.8.2.tgz/lib/assert/macros.js:180: assert.fail(actual, 'boolean', message || "expected {actual} to be a Boolean", "===", assert.isBoolean);
50710	vows-0.8.2.tgz/lib/assert/macros.js:186: assert.fail(actual, 'NaN', message || "expected {actual} to be NaN", "===", assert.isNaN);
50710	vows-0.8.2.tgz/lib/assert/macros.js:192: assert.fail(actual, null, message || "expected {expected}, got {actual}", "===", assert.isNull);
50710	vows-0.8.2.tgz/lib/assert/macros.js:198: assert.fail(actual, null, message || "expected non-null value, got {actual}", "===", assert.isNotNull);
50710	vows-0.8.2.tgz/lib/assert/macros.js:204: assert.fail(actual, undefined, message || "expected {actual} to be {expected}", "===", assert.isUndefined);
50710	vows-0.8.2.tgz/lib/assert/macros.js:210: assert.fail(actual, 0, message || "expected {actual} to be defined", "===", assert.isDefined);
50710	vows-0.8.2.tgz/lib/assert/macros.js:228: assert.fail(actual, expected, message || "expected {actual} to be an instance of {expected}", "instanceof", assert.instanceOf);
50710	vows-0.8.2.tgz/lib/assert/macros.js:238: assert.fail("", "", "expected number of arguments to be greater than zero", "", caller);
50710	vows-0.8.2.tgz/lib/assert/macros.js:244: assert.fail(actual, expected, message || "expected {actual} to be of type {expected}", "typeOf", caller);
// Unchecked
32865	gulp-usemin-0.3.29.tgz/test/main.js:80: assert.fail('', '', 'Should throw error', '');
32865	gulp-usemin-0.3.29.tgz/test/main.js:146: assert.fail('', '', 'should error', '');
32010	fakeredis-2.0.0.tgz/redis.test.js:114: assert.fail("Callback timed out!", name);
32010	fakeredis-2.0.0.tgz/redis.test.js:1637: assert.fail(err, name);
32010	fakeredis-2.0.0.tgz/redis.test.js:1671: assert.fail(err, name);
32010	fakeredis-2.0.0.tgz/redis.test.js:1688: assert.fail(err, name);
32010	fakeredis-2.0.0.tgz/redis.test.js:1697: assert.fail(err, name);
32010	fakeredis-2.0.0.tgz/redis.test.js:1741: assert.fail(err, name);
32010	fakeredis-2.0.0.tgz/redis.test.js:1749: assert.fail(err, name);
32010	fakeredis-2.0.0.tgz/redis.test.js:1757: assert.fail(err, name);
32010	fakeredis-2.0.0.tgz/redis.test.js:1767: assert.fail(err, name);
32010	fakeredis-2.0.0.tgz/redis.test.js:1799: assert.fail(err, name);
32010	fakeredis-2.0.0.tgz/redis.test.js:1827: assert.fail(err, name);
32010	fakeredis-2.0.0.tgz/redis.test.js:1856: assert.fail(err, name);
32010	fakeredis-2.0.0.tgz/redis.test.js:1863: assert.fail(err, name);
32010	fakeredis-2.0.0.tgz/redis.test.js:1914: assert.fail(err, name);
32010	fakeredis-2.0.0.tgz/redis.test.js:1921: assert.fail(err, name);
32010	fakeredis-2.0.0.tgz/redis.test.js:1931: assert.fail(err, name);
32010	fakeredis-2.0.0.tgz/redis.test.js:1938: assert.fail(err, name);
32010	fakeredis-2.0.0.tgz/redis.test.js:1947: assert.fail(err, name);
32010	fakeredis-2.0.0.tgz/redis.test.js:1956: assert.fail(err, name);
32010	fakeredis-2.0.0.tgz/redis.test.js:1965: assert.fail(err, name);
32010	fakeredis-2.0.0.tgz/redis.test.js:1976: assert.fail(err, name);
32010	fakeredis-2.0.0.tgz/redis.test.js:1982: assert.fail(err, name);
27440	glob-escape-0.0.2.tgz/test.js:16: assert.fail(matches, true, msg);
18228	serverless-iam-roles-per-function-1.0.4.tgz/src/test/index.test.ts:195: assert.fail(resource, undefined, "There shouldn't be extra roles beyond IamRoleLambdaExecution");
15566	filehound-1.17.0.tgz/test/filehound.js:1153: assert.fail(null, null, `Unexpected exception raised: ${err}`);
15061	optimizely-server-sdk-1.5.0.tgz/lib/plugins/event_dispatcher/tests.js:58: assert.fail('status code okay', 'status code not okay', "")
15061	optimizely-server-sdk-1.5.0.tgz/lib/plugins/event_dispatcher/tests.js:77: assert.fail('status code okay', 'status code not okay', "")
11205	core-1.0.113.tgz/lib/common/Assertions.js:78: assert.fail('not a instanceof', 'instanceof', message, '==', Assertions.isInstanceOf);
7984	firebase-bolt-0.8.4.tgz/lib/test/generator-test.js:410: assert.fail(undefined, undefined, "No exception thrown.");
7984	firebase-bolt-0.8.4.tgz/lib/test/parser-test.js:435: chai_1.assert.fail(undefined, undefined, "No exception thrown.");
7960	node-minizip-0.3.0.tgz/test/test.js:24: assert.fail(err, 'Expecting error');
7960	node-minizip-0.3.0.tgz/test/test.js:31: assert.fail(err, 'Expecting error');
7678	async_testing-0.3.2.tgz/test/test-custom_assertions.js:7: assert.fail(actual, 2, message, '==', isTwo);
6778	leaflet-editable-1.2.0.tgz/test/Editable.js:10: assert.fail(layer, null, 'no layer expected but one found');
6778	leaflet-editable-1.2.0.tgz/test/MiddleMarker.js:11: assert.fail(layer, null, 'no layer expected but one found');
6778	leaflet-editable-1.2.0.tgz/test/PolygonEditor.js:438: assert.fail(layer, null, 'no layer expected but one found');
6778	leaflet-editable-1.2.0.tgz/test/PolygonEditor.js:733: assert.fail(layer, null, 'no layer expected but one found');
6778	leaflet-editable-1.2.0.tgz/test/PolylineEditor.js:152: assert.fail(layer, null, 'no layer expected but one found');
6778	leaflet-editable-1.2.0.tgz/test/PolylineEditor.js:188: assert.fail(layer, null, 'no layer expected but one found');
6778	leaflet-editable-1.2.0.tgz/test/PolylineEditor.js:214: assert.fail(layer, null, 'no layer expected but one found before');
6778	leaflet-editable-1.2.0.tgz/test/PolylineEditor.js:220: assert.fail(layer, null, 'no layer expected but one found after');
6778	leaflet-editable-1.2.0.tgz/test/PolylineEditor.js:364: assert.fail(layer, null, 'no layer expected but one found');
6778	leaflet-editable-1.2.0.tgz/test/PolylineEditor.js:491: assert.fail(layer, null, 'no layer expected but one found');
6778	leaflet-editable-1.2.0.tgz/test/PolylineEditor.js:747: assert.fail(layer, null, 'no layer expected but one found');
6778	leaflet-editable-1.2.0.tgz/test/VertexMarker.js:14: assert.fail(layer, null, 'no layer expected but one found');
6228	fast-fuzzy-1.8.3.tgz/test.js:7: assert.fail(actual, expected, message, ">", assert.fail);
6228	fast-fuzzy-1.8.3.tgz/test.js:13: assert.fail(actual, expected, message, "<", assert.fail);
4969	nightwatch-accessibility-1.7.1.tgz/assertions/accessibility.js:45: this.assert.fail('policy violation', violation.helpUrl, `${violation.help} [${violation.nodes[0].html}]`)
4777	circular-buffer-1.0.2.tgz/test/test.js:88: assert.fail("No error after dequeueing empty buffer", "Error after dequeueing empty buffer");
4777	circular-buffer-1.0.2.tgz/test/test.js:99: assert.fail("No error after shifting empty buffer", "Error after shifting empty buffer");
4777	circular-buffer-1.0.2.tgz/test/test.js:158: assert.fail("No error after dequeueing empty buffer", "Error after dequeueing empty buffer");
4147	dns-cache-2.0.0.tgz/test/index.js:21: assert.fail(err.message, '', 'Error performing initial DNS lookup', "equals");
4147	dns-cache-2.0.0.tgz/test/index.js:34: assert.fail(err.message, '', 'Error performing DNS lookup with family instead of options', "equals");
4147	dns-cache-2.0.0.tgz/test/index.js:47: assert.fail(err.message, '', 'Error performing DNS lookup with all:true', "equals");
4147	dns-cache-2.0.0.tgz/test/index.js:61: assert.fail(err, 'Error', 'Error not returned for invalid hostname');
3867	githubot-1.0.1.tgz/test/request.coffee:142: assert.fail(null, null, "Success callback should not be invoked")
3367	beautify-benchmark-0.2.4.tgz/test.js:50: assert.fail('' + current + '%', '95%', null, '>=', done)
3271	seq-logging-0.3.0.tgz/test/seq_logger_tests.js:41: assert.fail(null, null, 'Expected an error');
3267	wix-restaurants-js-sdk-1.0.356.tgz/test/clients/WixRestaurantsAnalyticsClient.test.js:72: assert.fail(false, true, 'expected error');
3267	wix-restaurants-js-sdk-1.0.356.tgz/test/clients/WixRestaurantsAnalyticsClient.test.js:111: assert.fail(false, true, 'expected error');
3267	wix-restaurants-js-sdk-1.0.356.tgz/test/clients/WixRestaurantsAnalyticsClient.test.js:134: assert.fail(false, true, 'expected error');
3267	wix-restaurants-js-sdk-1.0.356.tgz/test/clients/WixRestaurantsAnalyticsClient.test.js:165: assert.fail(false, true, 'expected error');
3267	wix-restaurants-js-sdk-1.0.356.tgz/test/clients/WixRestaurantsClient.test.js:98: assert.fail(false, true, 'expected error');
3267	wix-restaurants-js-sdk-1.0.356.tgz/test/clients/WixRestaurantsClient.test.js:123: assert.fail(false, true, 'expected error');
3267	wix-restaurants-js-sdk-1.0.356.tgz/test/clients/WixRestaurantsClient.test.js:139: assert.fail(false, true, 'expected error');
3267	wix-restaurants-js-sdk-1.0.356.tgz/test/clients/WixRestaurantsClient.test.js:156: assert.fail(false, true, 'expected error');
3220	go-language-server-0.1.7.tgz/out/test/go.test.js:377: assert.fail(null, null, 'Failed to get patches for the test file', '');
3220	go-language-server-0.1.7.tgz/out/test/go.test.js:381: assert.fail(null, null, 'Failed to parse the file path from the diff output', '');
3220	go-language-server-0.1.7.tgz/out/test/go.test.js:385: assert.fail(null, null, 'Failed to parse edits from the diff output', '');
3220	go-language-server-0.1.7.tgz/out/test/go.test.js:414: assert.fail(null, null, 'Failed to get patches for the test file', '');
3220	go-language-server-0.1.7.tgz/out/test/go.test.js:419: assert.fail(null, null, 'Failed to parse the file path from the diff output', '');
3220	go-language-server-0.1.7.tgz/out/test/go.test.js:424: assert.fail(null, null, 'Failed to parse edits from the diff output', '');
3220	go-language-server-0.1.7.tgz/out/test/go.test.js:647: assert.fail('', entry, 'missing expected item in competion list', '');
3169	minivents-2.2.0.tgz/test.js:63: assert.fail(undefined, e, e.toString());
3169	minivents-2.2.0.tgz/test.js:72: assert.fail(undefined, e, e.toString());
3169	minivents-2.2.0.tgz/test.js:91: assert.fail(undefined, e, e.toString());
3169	minivents-2.2.0.tgz/test.js:101: assert.fail(undefined, e, e.toString());
3169	minivents-2.2.0.tgz/test.js:112: assert.fail(undefined, e, e.toString());
3169	minivents-2.2.0.tgz/test.js:118: f = function () { assert.fail(undefined, undefined, 'This function must not be executed.'); };
2800	foounit-0.1.2.tgz/src/matchers.js:67: assert.fail(actual, expected, null, '>');
2800	foounit-0.1.2.tgz/src/matchers.js:72: assert.fail(actual, expected, null, '<=');
2800	foounit-0.1.2.tgz/src/matchers.js:82: assert.fail(actual, expected, null, '<');
2800	foounit-0.1.2.tgz/src/matchers.js:87: assert.fail(actual, expected, null, '>=');
2800	foounit-0.1.2.tgz/src/matchers.js:208: assert.fail(actual, expected, null, 'is included in');
2800	foounit-0.1.2.tgz/src/matchers.js:213: assert.fail(actual, expected, null, 'is not included in');
2800	foounit-0.1.2.tgz/src/matchers.js:220: assert.fail(actual, expected, null, expected + ' matches');
2800	foounit-0.1.2.tgz/src/matchers.js:225: assert.fail(actual, expected, null, expected + ' does not match');
2800	foounit-0.1.2.tgz/templates/browser-node-suite/foounit/foounit.js:1018: assert.fail(actual, expected, null, '>');
2800	foounit-0.1.2.tgz/templates/browser-node-suite/foounit/foounit.js:1023: assert.fail(actual, expected, null, '<=');
2800	foounit-0.1.2.tgz/templates/browser-node-suite/foounit/foounit.js:1033: assert.fail(actual, expected, null, '<');
2800	foounit-0.1.2.tgz/templates/browser-node-suite/foounit/foounit.js:1038: assert.fail(actual, expected, null, '>=');
2800	foounit-0.1.2.tgz/templates/browser-node-suite/foounit/foounit.js:1159: assert.fail(actual, expected, null, 'is included in');
2800	foounit-0.1.2.tgz/templates/browser-node-suite/foounit/foounit.js:1164: assert.fail(actual, expected, null, 'is not included in');
2800	foounit-0.1.2.tgz/templates/browser-node-suite/foounit/foounit.js:1171: assert.fail(actual, expected, null, expected + ' matches');
2800	foounit-0.1.2.tgz/templates/browser-node-suite/foounit/foounit.js:1176: assert.fail(actual, expected, null, expected + ' does not match');
2800	foounit-0.1.2.tgz/templates/browser-node/foounit/foounit.js:1089: assert.fail(actual, expected, null, '>');
2800	foounit-0.1.2.tgz/templates/browser-node/foounit/foounit.js:1094: assert.fail(actual, expected, null, '<=');
2800	foounit-0.1.2.tgz/templates/browser-node/foounit/foounit.js:1104: assert.fail(actual, expected, null, '<');
2800	foounit-0.1.2.tgz/templates/browser-node/foounit/foounit.js:1109: assert.fail(actual, expected, null, '>=');
2800	foounit-0.1.2.tgz/templates/browser-node/foounit/foounit.js:1230: assert.fail(actual, expected, null, 'is included in');
2800	foounit-0.1.2.tgz/templates/browser-node/foounit/foounit.js:1235: assert.fail(actual, expected, null, 'is not included in');
2800	foounit-0.1.2.tgz/templates/browser-node/foounit/foounit.js:1242: assert.fail(actual, expected, null, expected + ' matches');
2800	foounit-0.1.2.tgz/templates/browser-node/foounit/foounit.js:1247: assert.fail(actual, expected, null, expected + ' does not match');
2800	foounit-0.1.2.tgz/templates/browser-suite/foounit/foounit.js:1018: assert.fail(actual, expected, null, '>');
2800	foounit-0.1.2.tgz/templates/browser-suite/foounit/foounit.js:1023: assert.fail(actual, expected, null, '<=');
2800	foounit-0.1.2.tgz/templates/browser-suite/foounit/foounit.js:1033: assert.fail(actual, expected, null, '<');
2800	foounit-0.1.2.tgz/templates/browser-suite/foounit/foounit.js:1038: assert.fail(actual, expected, null, '>=');
2800	foounit-0.1.2.tgz/templates/browser-suite/foounit/foounit.js:1159: assert.fail(actual, expected, null, 'is included in');
2800	foounit-0.1.2.tgz/templates/browser-suite/foounit/foounit.js:1164: assert.fail(actual, expected, null, 'is not included in');
2800	foounit-0.1.2.tgz/templates/browser-suite/foounit/foounit.js:1171: assert.fail(actual, expected, null, expected + ' matches');
2800	foounit-0.1.2.tgz/templates/browser-suite/foounit/foounit.js:1176: assert.fail(actual, expected, null, expected + ' does not match');
2800	foounit-0.1.2.tgz/templates/browser/foounit/foounit.js:1089: assert.fail(actual, expected, null, '>');
2800	foounit-0.1.2.tgz/templates/browser/foounit/foounit.js:1094: assert.fail(actual, expected, null, '<=');
2800	foounit-0.1.2.tgz/templates/browser/foounit/foounit.js:1104: assert.fail(actual, expected, null, '<');
2800	foounit-0.1.2.tgz/templates/browser/foounit/foounit.js:1109: assert.fail(actual, expected, null, '>=');
2800	foounit-0.1.2.tgz/templates/browser/foounit/foounit.js:1230: assert.fail(actual, expected, null, 'is included in');
2800	foounit-0.1.2.tgz/templates/browser/foounit/foounit.js:1235: assert.fail(actual, expected, null, 'is not included in');
2800	foounit-0.1.2.tgz/templates/browser/foounit/foounit.js:1242: assert.fail(actual, expected, null, expected + ' matches');
2800	foounit-0.1.2.tgz/templates/browser/foounit/foounit.js:1247: assert.fail(actual, expected, null, expected + ' does not match');
2574	audiosprite-0.7.1.tgz/test/test.js:84: assert.fail(code, 0, 'audiosprite returned with error code. debug = ' + err, '==');
2490	boolean-expression-2.0.0.tgz/test.js:40: else assert.fail('Map method called for other thing than token', e)
2455	typ-0.6.3.tgz/lib/typ.js:166: assert.fail(gotType, expectedTypeName, message, "!==");
2455	typ-0.6.3.tgz/test/test.js:153: assert.fail("no exception", ex, msg);
2455	typ-0.6.3.tgz/test/test.js:158: assert.fail(!expectTrue, expectTrue, msg);
2455	typ-0.6.3.tgz/test/test.js:171: assert.fail(!expectTrue, expectTrue, msg);
2455	typ-0.6.3.tgz/test/test.js:179: assert.fail(true, false, msg);
2455	typ-0.6.3.tgz/test/test.js:194: assert.fail(true, false, "Failed to throw.");
2060	generator-ibm-java-5.14.0.tgz/lib/assert/internal/assert.kube.js:68: assert.fail(i, 'i < 2', 'Yaml file contains more documents than expected');
2060	generator-ibm-java-5.14.0.tgz/lib/common/test/unit/fsprocessor.test.js:83: assert.fail(false, true, "Should not have found any projects");
2060	generator-ibm-java-5.14.0.tgz/lib/common/test/unit/fsprocessor.test.js:85: assert.fail(false, true, "Walk should not have completed without error");
2060	generator-ibm-java-5.14.0.tgz/lib/common/test/unit/fsprocessor.test.js:103: assert.fail(false, true, "Should not have found any projects");
2060	generator-ibm-java-5.14.0.tgz/lib/common/test/unit/fsprocessor.test.js:106: assert.fail(false, true, "Walk should not have completed without error");
1983	event-store-client-1.0.0.tgz/test/catchUpSubscription.js:36: assert.fail(null, null, 'Subscription dropped!');
1983	event-store-client-1.0.0.tgz/test/catchUpSubscription.js:103: assert.fail(null, null, 'Subscription dropped!');
1960	nuclide-0.366.0.tgz/modules/atom-ide-debugger-python/VendorLib/vs-py-debugger/out/test/common/helpers.test.js:28: assert.fail(value, 'Error', 'Was expecting promise to get rejected, however it was resolved', '');
1960	nuclide-0.366.0.tgz/modules/atom-ide-debugger-python/VendorLib/vs-py-debugger/out/test/definitions/hover.jedi.test.js:257: assert.fail(contents, '', 'First line is incorrect', 'compare');
1960	nuclide-0.366.0.tgz/modules/atom-ide-debugger-python/VendorLib/vs-py-debugger/out/test/definitions/hover.jedi.test.js:260: assert.fail(contents, '', 'Variable name or type are missing', 'compare');
1960	nuclide-0.366.0.tgz/modules/atom-ide-debugger-python/VendorLib/vs-py-debugger/out/test/definitions/hover.jedi.test.js:273: assert.fail(contents, '', '\'def my_func\' is missing', 'compare');
1960	nuclide-0.366.0.tgz/modules/atom-ide-debugger-python/VendorLib/vs-py-debugger/out/test/definitions/hover.jedi.test.js:277: assert.fail(contents, '', 'Expected custom function text missing', 'compare');
1960	nuclide-0.366.0.tgz/modules/atom-ide-debugger-python/VendorLib/vs-py-debugger/out/test/definitions/hover.ls.test.js:201: assert.fail(contents, '', 'Variable type is missing', 'compare');
1960	nuclide-0.366.0.tgz/modules/atom-ide-debugger-python/VendorLib/vs-py-debugger/out/test/definitions/hover.ls.test.js:214: assert.fail(contents, '', '\'capitalize\' is missing', 'compare');
1960	nuclide-0.366.0.tgz/modules/atom-ide-debugger-python/VendorLib/vs-py-debugger/out/test/definitions/hover.ls.test.js:218: assert.fail(contents, '', '\'Return a capitalized version of S/Return a copy of the string S with only its first character\' message missing', 'compare');
1960	nuclide-0.366.0.tgz/modules/atom-ide-debugger-python/VendorLib/vs-py-debugger/out/test/format/extension.onTypeFormat.test.js:48: assert.fail(reason, undefined, 'Type Formatting failed', '');
1960	nuclide-0.366.0.tgz/modules/atom-ide-debugger-python/VendorLib/vs-py-debugger/out/test/refactor/extension.refactor.extract.method.test.js:70: assert.fail('No error', 'Error', 'Extraction should fail with an error', '');
1960	nuclide-0.366.0.tgz/modules/atom-ide-debugger-python/VendorLib/vs-py-debugger/out/test/refactor/extension.refactor.extract.method.test.js:109: assert.fail('No error', 'Error', 'Extraction should fail with an error', '');
1960	nuclide-0.366.0.tgz/modules/atom-ide-debugger-python/VendorLib/vs-py-debugger/out/test/refactor/extension.refactor.extract.var.test.js:70: assert.fail('No error', 'Error', 'Extraction should fail with an error', '');
1960	nuclide-0.366.0.tgz/modules/atom-ide-debugger-python/VendorLib/vs-py-debugger/out/test/refactor/extension.refactor.extract.var.test.js:118: assert.fail('No error', 'Error', 'Extraction should fail with an error', '');
1960	nuclide-0.366.0.tgz/modules/atom-ide-debugger-python/VendorLib/vs-py-debugger/out/test/refactor/extension.refactor.extract.var.test.js:129: assert.fail('Error', 'No error', `${error}`);
1960	nuclide-0.366.0.tgz/modules/atom-ide-debugger-python/VendorLib/vs-py-debugger/out/test/stub.js:149: chai_1.assert.fail(null, err, 'the next err was unexpectedly not null');
1916	remotedebug-ios-webkit-adapter-0.3.1.tgz/out/protocols/target.test.js:178: assert.fail('the adapter calling the target should not have sent a message to the tools', '', '', '');
1916	remotedebug-ios-webkit-adapter-0.3.1.tgz/out/protocols/target.test.js:181: assert.fail('the adapter calling the target should not have emitted an event, it should resolve the promise instead', '', '', '');
1916	remotedebug-ios-webkit-adapter-0.3.1.tgz/out/protocols/target.test.js:212: assert.fail('promise should not have succeeded', '', '', '');
1916	remotedebug-ios-webkit-adapter-0.3.1.tgz/out/protocols/target.test.js:295: assert.fail('message should have been sent to the new server', '', '', '');
1912	chatdown-1.1.0.tgz/test/chatdown.lib.test.suite.js:125: assert.fail('did not throw', 'will throw');
1711	remix-ide-0.7.5-local.tgz/src/app/debugger/remix-debugger/test-browser-debugger/test/vmdebugger.js:47: browser.assert.fail(' txinput panel does not contain <not found> ', 'info about error', '')
1711	remix-ide-0.7.5-local.tgz/src/app/debugger/remix-debugger/test-browser-debugger/test/vmdebugger.js:63: browser.assert.fail(' txinput panel does not contain 0x20ef65b8b186ca942fcccd634f37074dde49b541c27994fc7596740ef44cfd51 ', 'info about error', '')
1711	remix-ide-0.7.5-local.tgz/test-browser-debugger/test/vmdebugger.js:44: browser.assert.fail(' error with transaction hash should have been displayed', 'info about error', '')
1711	remix-ide-0.7.5-local.tgz/test-browser/helpers/contracts.js:66: browser.assert.fail('compiled contract ' + compiledContractNames + ' not found', 'info about error', '')
1711	remix-ide-0.7.5-local.tgz/test-browser/helpers/contracts.js:72: browser.assert.fail('compiled contract ' + compiledContractNames + ' not found - none found', 'info about error', '')
1711	remix-ide-0.7.5-local.tgz/test-browser/helpers/contracts.js:179: client.assert.fail('expected ' + expectedReturn + ' got ' + result.value, 'info about error', '')
1711	remix-ide-0.7.5-local.tgz/test-browser/helpers/contracts.js:191: client.assert.fail('expected ' + expectedEvent + ' got ' + result.value, 'info about error', '')
1711	remix-ide-0.7.5-local.tgz/test-browser/helpers/contracts.js:360: browser.assert.fail('useFilter on ' + filter + ' ' + test, 'info about error', '')
1711	remix-ide-0.7.5-local.tgz/test-browser/helpers/contracts.js:387: browser.assert.fail('cant parse solidity state', e.message, '')
1711	remix-ide-0.7.5-local.tgz/test-browser/helpers/contracts.js:393: browser.assert.fail('checkDebug on ' + id, 'info about error', '')
1711	remix-ide-0.7.5-local.tgz/test-browser/helpers/contracts.js:408: browser.assert.fail('goToVMtraceStep fails', 'info about error', '')
1701	redis-client-0.3.5.tgz/test/test.js:101: if (err) assert.fail(err, context);
1701	redis-client-0.3.5.tgz/test/test.js:121: if (err) assert.fail(err, context);
1701	redis-client-0.3.5.tgz/test/test.js:321: if (err) assert.fail(err, "testGET");
1701	redis-client-0.3.5.tgz/test/test.js:326: if (err) assert.fail(err, "testGET");
1701	redis-client-0.3.5.tgz/test/test.js:336: if (err) assert.fail(err, "testMGET");
1701	redis-client-0.3.5.tgz/test/test.js:344: if (err) assert.fail(err, "testMGET");
1701	redis-client-0.3.5.tgz/test/test.js:354: if (err) assert.fail(err, "testGETSET 1");
1701	redis-client-0.3.5.tgz/test/test.js:359: if (err) assert.fail(err, "testGETSET 3");
1701	redis-client-0.3.5.tgz/test/test.js:371: if (err) assert.fail(err, "testSETANDGETMULTIBYTE");
1701	redis-client-0.3.5.tgz/test/test.js:426: if (err) assert.fail(err, "testKEYS");
1701	redis-client-0.3.5.tgz/test/test.js:438: if (err) assert.fail(err, "testKEYS");
1701	redis-client-0.3.5.tgz/test/test.js:445: if (err) assert.fail(err, "testKEYS");
1701	redis-client-0.3.5.tgz/test/test.js:457: if (err) assert.fail(err, "testKEYS");
1701	redis-client-0.3.5.tgz/test/test.js:469: if (err) assert.fail(err, "testRANDOMKEY");
1701	redis-client-0.3.5.tgz/test/test.js:497: if (err) assert.fail(err, "testDBSIZE");
1701	redis-client-0.3.5.tgz/test/test.js:519: if (err) assert.fail(err, "testEXPIRE");
1701	redis-client-0.3.5.tgz/test/test.js:530: if (err) assert.fail(err, "testSETEX");
1701	redis-client-0.3.5.tgz/test/test.js:539: if (err) assert.fail(err, "testSETEX");
1701	redis-client-0.3.5.tgz/test/test.js:552: if (err) assert.fail(err, "testTTL");
1701	redis-client-0.3.5.tgz/test/test.js:560: if (err) assert.fail(err, "testTTL");
1701	redis-client-0.3.5.tgz/test/test.js:589: if (err) assert.fail(err, "testLRANGE");
1701	redis-client-0.3.5.tgz/test/test.js:596: if (err) assert.fail(err, "testLRANGE");
1701	redis-client-0.3.5.tgz/test/test.js:602: if (err) assert.fail(err, "testLRANGE");
1701	redis-client-0.3.5.tgz/test/test.js:614: if (err) assert.fail(err, "testLTRIM");
1701	redis-client-0.3.5.tgz/test/test.js:621: if (err) assert.fail(err, "testLTRIM");
1701	redis-client-0.3.5.tgz/test/test.js:626: if (err) assert.fail(err, "testLTRIM");
1701	redis-client-0.3.5.tgz/test/test.js:638: if (err) assert.fail(err, "testLINDEX");
1701	redis-client-0.3.5.tgz/test/test.js:643: if (err) assert.fail(err, "testLINDEX");
1701	redis-client-0.3.5.tgz/test/test.js:650: if (err) assert.fail(err, "testLINDEX");
1701	redis-client-0.3.5.tgz/test/test.js:660: if (err) assert.fail(err, "testLSET");
1701	redis-client-0.3.5.tgz/test/test.js:674: if (err) assert.fail(err, "testLREM");
1701	redis-client-0.3.5.tgz/test/test.js:687: if (err) assert.fail(err, "testLPOP");
1701	redis-client-0.3.5.tgz/test/test.js:692: if (err) assert.fail(err, "testLPOP");
1701	redis-client-0.3.5.tgz/test/test.js:697: if (err) assert.fail(err, "testLPOP");
1701	redis-client-0.3.5.tgz/test/test.js:708: if (err) assert.fail(err, "testRPOP");
1701	redis-client-0.3.5.tgz/test/test.js:713: if (err) assert.fail(err, "testRPOP");
1701	redis-client-0.3.5.tgz/test/test.js:718: if (err) assert.fail(err, "testRPOP");
1701	redis-client-0.3.5.tgz/test/test.js:728: if (err) assert.fail(err, "testRPOPLPUSH");
1701	redis-client-0.3.5.tgz/test/test.js:733: if (err) assert.fail(err, "testRPOPLPUSH");
1701	redis-client-0.3.5.tgz/test/test.js:739: if (err) assert.fail(err, "testRPOPLPUSH");
1701	redis-client-0.3.5.tgz/test/test.js:776: if (err) assert.fail(err, "testSPOP");
1701	redis-client-0.3.5.tgz/test/test.js:795: if (err) assert.fail(err, "testSDIFF");
1701	redis-client-0.3.5.tgz/test/test.js:819: if (err) assert.fail(err, "testSDIFFSTORE");
1701	redis-client-0.3.5.tgz/test/test.js:830: if (err) assert.fail(err, "testSMEMBERS");
1701	redis-client-0.3.5.tgz/test/test.js:838: if (err) assert.fail(err, "testSMEMBERS");
1701	redis-client-0.3.5.tgz/test/test.js:867: if (err) assert.fail(err, "testSINTER");
1701	redis-client-0.3.5.tgz/test/test.js:874: if (err) assert.fail(err, "testSINTER");
1701	redis-client-0.3.5.tgz/test/test.js:881: if (err) assert.fail(err, "testSINTER");
1701	redis-client-0.3.5.tgz/test/test.js:889: if (err) assert.fail(err, "testSINTER");
1701	redis-client-0.3.5.tgz/test/test.js:911: if (err) assert.fail(err, "testSINTERSTORE");
1701	redis-client-0.3.5.tgz/test/test.js:931: if (err) assert.fail(err, "testUNION");
1701	redis-client-0.3.5.tgz/test/test.js:951: if (err) assert.fail(err, "testUNIONSTORE");
1701	redis-client-0.3.5.tgz/test/test.js:956: if (err) assert.fail(err, "testUNIONSTORE");
1701	redis-client-0.3.5.tgz/test/test.js:966: if (err) assert.fail(err, "testTYPE");
1701	redis-client-0.3.5.tgz/test/test.js:972: if (err) assert.fail(err, "testTYPE");
1701	redis-client-0.3.5.tgz/test/test.js:978: if (err) assert.fail(err, "testTYPE");
1701	redis-client-0.3.5.tgz/test/test.js:983: if (err) assert.fail(err, "testTYPE");
1701	redis-client-0.3.5.tgz/test/test.js:1101: if (err) assert.fail(err, "testSORT");
1701	redis-client-0.3.5.tgz/test/test.js:1107: if (err) assert.fail(err, "testSORT");
1701	redis-client-0.3.5.tgz/test/test.js:1116: if (err) assert.fail(err, "testSORT");
1701	redis-client-0.3.5.tgz/test/test.js:1122: if (err) assert.fail(err, "testSORT");
1701	redis-client-0.3.5.tgz/test/test.js:1130: if (err) assert.fail(err, "testSORT");
1701	redis-client-0.3.5.tgz/test/test.js:1138: if (err) assert.fail(err, "testSORT");
1701	redis-client-0.3.5.tgz/test/test.js:1146: if (err) assert.fail(err, "testSORT");
1701	redis-client-0.3.5.tgz/test/test.js:1156: if (err) assert.fail(err, "testSORT");
1701	redis-client-0.3.5.tgz/test/test.js:1160: if (err) assert.fail(err, "testSORT");
1701	redis-client-0.3.5.tgz/test/test.js:1176: if (err) assert.fail(err, "testLASTSAVE");
1701	redis-client-0.3.5.tgz/test/test.js:1245: if (err) assert.fail(err, "testZSCORE");
1701	redis-client-0.3.5.tgz/test/test.js:1256: if (err) assert.fail(err, "testZRANGE");
1701	redis-client-0.3.5.tgz/test/test.js:1262: if (err) assert.fail(err, "testZRANGE");
1701	redis-client-0.3.5.tgz/test/test.js:1268: if (err) assert.fail(err, "testZRANGE");
1701	redis-client-0.3.5.tgz/test/test.js:1280: if (err) assert.fail(err, "testZREVRANGE");
1701	redis-client-0.3.5.tgz/test/test.js:1292: if (err) assert.fail(err, "testZRANGEBYSCORE 4");
1701	redis-client-0.3.5.tgz/test/test.js:1298: if (err) assert.fail(err, "testZRANGEBYSCORE 6");
1701	redis-client-0.3.5.tgz/test/test.js:1304: if (err) assert.fail(err, "testZRANGEBYSCORE 8");
1701	redis-client-0.3.5.tgz/test/test.js:1335: if (err) assert.fail(err, "testZINTER");
1701	redis-client-0.3.5.tgz/test/test.js:1347: if (err) assert.fail(err, "testZUNION");
1701	redis-client-0.3.5.tgz/test/test.js:1385: if (err) assert.fail(err, "testZREMRANGEBYRANK");
1701	redis-client-0.3.5.tgz/test/test.js:1404: if (err) assert.fail(err, "testZREMRANGEBYSCORE");
1701	redis-client-0.3.5.tgz/test/test.js:1429: if (err) assert.fail(err, "testHGET");
1701	redis-client-0.3.5.tgz/test/test.js:1438: if (err) assert.fail(err, "testHGETALL");
1701	redis-client-0.3.5.tgz/test/test.js:1456: if (err) assert.fail(err, "testHKEYS");
1701	redis-client-0.3.5.tgz/test/test.js:1466: if (err) assert.fail(err, "testHVALS");
1701	redis-client-0.3.5.tgz/test/test.js:1483: if (err) assert.fail(err, "testHSET");
1701	redis-client-0.3.5.tgz/test/test.js:1499: if (err) assert.fail(err, "testSUBSCRIBE");
1701	redis-client-0.3.5.tgz/test/test.js:1505: if (err) assert.fail(err, "testSUBSCRIBE");
1701	redis-client-0.3.5.tgz/test/test.js:1511: if (err) assert.fail(err, "testSUBSCRIBE");
1701	redis-client-0.3.5.tgz/test/test.js:1517: if (err) assert.fail(err, "testSUBSCRIBE");
1701	redis-client-0.3.5.tgz/test/test.js:1529: if (err) assert.fail(err, "testPSUBSCRIBE");
1701	redis-client-0.3.5.tgz/test/test.js:1535: if (err) assert.fail(err, "testPSUBSCRIBE");
1701	redis-client-0.3.5.tgz/test/test.js:1573: if (err) assert.fail(err, "testSUBSCRIBEandPUBLISH b0");
1701	redis-client-0.3.5.tgz/test/test.js:1590: if (err) assert.fail(err, "testBLPOP 2");
1701	redis-client-0.3.5.tgz/test/test.js:1600: if (err) assert.fail(err, "testBLPOP 5");
1701	redis-client-0.3.5.tgz/test/test.js:1609: if (err) assert.fail(err, "testBLPOP 7");
1701	redis-client-0.3.5.tgz/test/test.js:1622: if (err) assert.fail(err, "testBRPOP");
1701	redis-client-0.3.5.tgz/test/test.js:1632: if (err) assert.fail(err, "testBRPOP");
1701	redis-client-0.3.5.tgz/test/test.js:1641: if (err) assert.fail(err, "testBRPOP");
1701	redis-client-0.3.5.tgz/test/test.js:1751: if (err) assert.fail(err, "testLargeGetSet; 1");
1701	redis-client-0.3.5.tgz/test/test.js:1760: if (err) assert.fail(err, "testGET (large; 1)");
1701	redis-client-0.3.5.tgz/test/test.js:1764: if (err) assert.fail(err, "testGET (large; 3)");
1701	redis-client-0.3.5.tgz/test/test.js:1814: if (err) assert.fail(err, "testStoreAnImage (large; 1)");
1701	redis-client-0.3.5.tgz/test/test.js:1818: if (err) assert.fail(err, "testStoreAnImage (large; 3)");
1613	gulp-group-aggregate-0.2.0.tgz/test/main.js:30: assert.fail(data.str, "'a' or 'b'", 'aggregate should only create object with an existing str')
1613	gulp-group-aggregate-0.2.0.tgz/test/main.js:65: assert.fail(data.str, "'a' or 'b'", 'aggregate should only create object with an existing str')
1593	marzipano-0.8.0.tgz/test/assert.js:22: assert.fail(actual, expected, msg, 'closeTo');
1593	marzipano-0.8.0.tgz/test/assert.js:28: assert.fail(actual, expected, msg, 'sameElements');
1593	marzipano-0.8.0.tgz/test/assert.js:32: assert.fail(actual, expected, msg, 'sameElements');
1516	roosevelt-less-0.7.1.tgz/test/unit/rooseveltLessTest.js:333: assert.fail('the app was able to initialize, meaning that roosevelt-less was not able to detect the error')
1450	cip-1.0.1.tgz/test/cip.test.js:11: assert.fail(actual, expected, message, operator)
1436	super-request-1.2.0.tgz/test/request.test.js:287: assert.fail(err.message, expectedMessage);
1436	super-request-1.2.0.tgz/test/request.test.js:337: assert.fail(err.message, expectedMessage);
1436	super-request-1.2.0.tgz/test/request.test.js:361: assert.fail(err.message, expectedMessage);
1436	super-request-1.2.0.tgz/test/request.test.js:396: assert.fail(err.message, expectedMessage);
1436	super-request-1.2.0.tgz/test/request.test.js:418: assert.fail(err.message, expectedMessage);
1436	super-request-1.2.0.tgz/test/request.test.js:439: assert.fail(err.message, expectedMessage);
1436	super-request-1.2.0.tgz/test/request.test.js:474: assert.fail(err.message, expectedMessage);
1436	super-request-1.2.0.tgz/test/request.test.js:493: assert.fail(err.message, expectedMessage);
1436	super-request-1.2.0.tgz/test/request.test.js:513: assert.fail(err.message, expectedMessage);
1436	super-request-1.2.0.tgz/test/request.test.js:559: assert.fail(err.message, expectedMessage);
1423	roosevelt-0.12.2.tgz/test/unit/publicFolderTest.js:118: assert.fail(`able to get the favicon.ico, even when there isn't one`)
1423	roosevelt-0.12.2.tgz/test/unit/publicFolderTest.js:168: assert.fail(`able to get the favicon.ico, even when there isn't one`)
1380	automerge-0.9.2.tgz/test/proxies_test.js:274: doc.empty.forEach(() => { assert.fail('was called', 'not called', 'callback error') })
1380	automerge-0.9.2.tgz/test/test.js:614: assert.fail(s1.field, 'string or list or map', 'not one of the expected values')
1301	parse-mockdb-0.2.1.tgz/test/test.js:103: assert.fail(null, null, 'should not have saved');
1301	parse-mockdb-0.2.1.tgz/test/test.js:156: assert.fail(null, null, 'should not have deleted');
1145	spring-cloud-config-2.0.0.tgz/test/unit/config-test.js:16: assert.fail("Error", "Success", JSON.stringify(error.message));
1145	spring-cloud-config-2.0.0.tgz/test/unit/config-test.js:27: assert.fail("Error", "Success", JSON.stringify(error.message));
1145	spring-cloud-config-2.0.0.tgz/test/unit/config-test.js:37: assert.fail("Error", "Success", JSON.stringify(error.message));
1145	spring-cloud-config-2.0.0.tgz/test/unit/config-test.js:226: assert.fail('an error', 'success', error.message);
1145	spring-cloud-config-2.0.0.tgz/test/unit/config-test.js:237: assert.fail('an error', 'success', error.message);
1145	spring-cloud-config-2.0.0.tgz/test/unit/config-test.js:248: assert.fail('an error', 'success', error.message);
1145	spring-cloud-config-2.0.0.tgz/test/unit/config-test.js:261: assert.fail('an error', 'success', error.message);
1145	spring-cloud-config-2.0.0.tgz/test/unit/config-test.js:276: assert.fail("Error", "Success", JSON.stringify(error.message));
1145	spring-cloud-config-2.0.0.tgz/test/unit/config-test.js:296: assert.fail('did not fail', 'a failure', 'this attempt should fail');
1145	spring-cloud-config-2.0.0.tgz/test/unit/config-test.js:307: assert.fail('did not fail', 'a failure', 'this attempt should fail');
1145	spring-cloud-config-2.0.0.tgz/test/unit/config-test.js:321: assert.fail('did not fail', 'a failure', 'this attempt should fail');
1145	spring-cloud-config-2.0.0.tgz/test/unit/config-test.js:335: assert.fail('did not fail', 'a failure', 'this attempt should fail');
1145	spring-cloud-config-2.0.0.tgz/test/unit/config-test.js:356: assert.fail("Error", "Success", JSON.stringify(error.message));
1145	spring-cloud-config-2.0.0.tgz/test/unit/config-test.js:376: assert.fail("Error", "Success", JSON.stringify(error.message));
1145	spring-cloud-config-2.0.0.tgz/test/unit/config-test.js:395: assert.fail("Error", "Success", JSON.stringify(error.message));
1145	spring-cloud-config-2.0.0.tgz/test/unit/config-test.js:415: assert.fail("Error", "Success", JSON.stringify(error.message));
1145	spring-cloud-config-2.0.0.tgz/test/unit/config-test.js:443: assert.fail("Error", "Success", JSON.stringify(error.message));
1145	spring-cloud-config-2.0.0.tgz/test/unit/config-test.js:471: assert.fail("Error", "Success", JSON.stringify(error.message));
1145	spring-cloud-config-2.0.0.tgz/test/unit/config-test.js:502: assert.fail("Error", "Success", JSON.stringify(error.message));
1100	e2-2.0.0.tgz/test/test.js:39: assert.fail('called', 'not called');
1092	react-native-ci-tools-1.1.0.tgz/src/utils/check_path.spec.js:27: .then(result => assert.fail(0, 1, 'Expcected and exception, but got a result!'))
1092	react-native-ci-tools-1.1.0.tgz/src/utils/check_path.spec.js:34: .then(result => assert.fail(0, 1, 'Expcected and exception, but got a result!'))
1092	react-native-ci-tools-1.1.0.tgz/src/utils/check_path.spec.js:42: .then(result => assert.fail(0, 1, 'Expcected and exception, but got a result!'))
1092	react-native-ci-tools-1.1.0.tgz/src/utils/check_path.spec.js:92: .then(result => assert.fail(0, 1, 'Expcected and exception, but got a result!'))
1092	react-native-ci-tools-1.1.0.tgz/src/utils/check_path.spec.js:120: .then(result => assert.fail(0, 1, 'Expcected and exception, but got a result!'))
1092	react-native-ci-tools-1.1.0.tgz/src/utils/glob_search.spec.js:27: .then(result => assert.fail(0, 1, 'Expcected and exception, but got a result!'))
1092	react-native-ci-tools-1.1.0.tgz/src/utils/glob_search.spec.js:35: .then(result => assert.fail(0, 1, 'Expcected and exception, but got a result!'))
1092	react-native-ci-tools-1.1.0.tgz/src/utils/glob_search.spec.js:76: .then(result => assert.fail(0, 1, 'Expcected and exception, but got a result!'))
1092	react-native-ci-tools-1.1.0.tgz/src/utils/plist_build.spec.js:24: .then(result => assert.fail(0, 1, 'Expcected and exception, but got a result!'))
1092	react-native-ci-tools-1.1.0.tgz/src/utils/plist_build.spec.js:32: .then(result => assert.fail(0, 1, 'Expcected and exception, but got a result!'))
1092	react-native-ci-tools-1.1.0.tgz/src/utils/plist_build.spec.js:41: .then(result => assert.fail(0, 1, 'Expcected and exception, but got a result!'))
1092	react-native-ci-tools-1.1.0.tgz/src/utils/plist_parse.spec.js:24: .then(result => assert.fail(0, 1, 'Expcected and exception, but got a result!'))
1092	react-native-ci-tools-1.1.0.tgz/src/utils/plist_parse.spec.js:32: .then(result => assert.fail(0, 1, 'Expcected and exception, but got a result!'))
1092	react-native-ci-tools-1.1.0.tgz/src/utils/plist_parse.spec.js:41: .then(result => assert.fail(0, 1, 'Expcected and exception, but got a result!'))
1089	qassert-1.6.1.tgz/qassert.js:150: assert.fail(actual, expected, null, operator, stackStartFunction);
1002	postcss-twist-url-assets-1.0.0.tgz/test/test.js:42: assert.fail(true, false, filePath + ' does not exist');

@nodejs-github-bot

nodejs-github-bot commented May 3, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22922/

@BridgeAR

BridgeAR commented May 7, 2019

Copy link
Copy Markdown
MemberAuthor

After thinking about this again for a while I believe it's actually fine to keep this deprecation around for a significantly longer time. It does not hurt keeping the code and even though this will likely not be an issue for users there's also not much we gain by doing it now. If we wait e.g., two more years people might have refactored their code and updated more cases but this is mainly used as a "this code branch should never be reached" thing and thus they will also not be notified that this API is deprecated.

@BridgeARBridgeAR closed this May 7, 2019
@zero1fivezero1five mentioned this pull request May 16, 2019
Closed
4 tasks
@BridgeAR
BridgeAR deleted the remove-deprecated-assert-fail branch January 20, 2020 12:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@targostargostargos approved these changes
@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

assertIssues and PRs related to the assert subsystem.author readyPRs that have at least one approval, no pending requests for changes, and a CI started.semver-majorPRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@BridgeAR@nodejs-github-bot@Trott@benjamingr@targos@trivikr