Uh oh!
There was an error while loading. Please reload this page.
doc: update n-api version support matrix - #27567
Conversation
hiroppy
commented
May 4, 2019
Please change the commit message format. See https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
As thread safe functions were back-ported to 8.x and released in 8.16 the documentation should be updated as well.
Trott
commented
May 5, 2019
Hi, @teams2ua! Welcome and thanks for the pull request! Looks good to me, but let's loop in the N-API experts: ping @nodejs/n-api |
mhdawson
commented
May 17, 2019
In case anybody else was going to confirm as well: https://github.com/nodejs/node/blob/v8.x/src/node_version.h shows NAPI_VERSION as 4. |
mhdawson
commented
May 17, 2019
@gabrielschulhof I assume the backport is still in progress for 10.X or we just need a release to come out? |
richardlau
commented
May 17, 2019
@mhdawson I think the backport is in the v10.16.0 proposal -- I asked a question about whether the support matrix needs to be updated in the v10.16.0 release: #27514 (comment) |
richardlau
commented
May 17, 2019
mhdawson
commented
May 17, 2019
@richardlau thanks for the update. |
addaleax
commented
May 26, 2019
Landed in 73c16b1 |
As thread safe functions were back-ported to 8.x and released in 8.16 the documentation should be updated as well. PR-URL: #27567 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
As thread safe functions were back-ported to 8.x and released in 8.16 the documentation should be updated as well. PR-URL: #27567 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
As thread safe functions were back-ported to 8.x and released in 8.16
Checklist