Uh oh!
There was an error while loading. Please reload this page.
repl: do not run --eval code if there is none - #27587
Closed
addaleax wants to merge 2 commits into
Closed
Conversation
`getOptionValue('--eval')` always returns a string, so it is never
loose-equal to `null`. Running eval makes some modifications to the
global object, including setting `module` to a different value, which
we want to avoid if possible.
Refs: nodejs#27278Fixes: nodejs#27575nodejs-github-bot
commented
May 6, 2019
Collaborator
BridgeAR
approved these changes
May 6, 2019
BridgeAR
commented
May 6, 2019
Member
@addaleax this keeps on failing? Does it maybe only fix some cases? (I did not check closer) |
Trott
approved these changes
May 6, 2019
jdalton
approved these changes
May 6, 2019
addaleax
commented
May 6, 2019
MemberAuthor
@BridgeAR Yes, thanks for pointing that out – my test was better than my code. I’ve added another commit that should solve that issue (and probably technically renders the former commit unnecessary, but I still think it’s more correct this way). |
cjihrig
approved these changes
May 7, 2019
devsnek
approved these changes
May 7, 2019
fhinkel
approved these changes
May 9, 2019
jasnell
approved these changes
May 10, 2019
nodejs-github-bot
commented
May 10, 2019
Collaborator
nodejs-github-bot
commented
May 11, 2019
Collaborator
nodejs-github-bot
commented
May 12, 2019
Collaborator
joyeecheung
approved these changes
May 12, 2019
joyeecheung
left a comment
Member
There was a problem hiding this comment.
Should lib/internal/main/eval_string.js be fixed as well?
addaleax
commented
May 12, 2019
MemberAuthor
@joyeecheung I don’t think so, because at that point it’s already clear that there is an |
addaleax
commented
May 12, 2019
MemberAuthor
Landed in 1d31c68...b230833 |
addaleax added a commit
that referenced
this pull request
May 12, 2019
`getOptionValue('--eval')` always returns a string, so it is never
loose-equal to `null`. Running eval makes some modifications to the
global object, including setting `module` to a different value, which
we want to avoid if possible.
Refs: #27278
PR-URL: #27587
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>addaleax added a commit
that referenced
this pull request
May 12, 2019
PR-URL: #27587Fixes: #27575 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
joyeecheung
commented
May 12, 2019
Member
@addaleax ah, right, in that case there is already a |
targos pushed a commit
that referenced
this pull request
May 13, 2019
`getOptionValue('--eval')` always returns a string, so it is never
loose-equal to `null`. Running eval makes some modifications to the
global object, including setting `module` to a different value, which
we want to avoid if possible.
Refs: #27278
PR-URL: #27587
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>targos pushed a commit
that referenced
this pull request
May 13, 2019
PR-URL: #27587Fixes: #27575 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getOptionValue('--eval')always returns a string, so it is neverloose-equal to
null. Running eval makes some modifications to theglobal object, including setting
moduleto a different value, whichwe want to avoid if possible.
Refs: #27278
Fixes: #27575
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes