Skip to content

module: handle relative paths in resolve paths - #27598

Merged
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:27583
May 9, 2019
Merged

module: handle relative paths in resolve paths#27598
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:27583

Conversation

@cjihrig

@cjihrigcjihrig commented May 7, 2019

Copy link
Copy Markdown
Contributor

This commit adds support for relative paths in require.resolve()'s paths option.

Fixes: #27583

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented May 7, 2019

Copy link
Copy Markdown
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3452

@cjihrigcjihrig mentioned this pull request May 7, 2019
Closed
targos
targos reviewed May 7, 2019
View reviewed changes
Comment threadlib/internal/modules/cjs/loader.js Outdated
@nodejs-github-bot

nodejs-github-bot commented May 8, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22998/

@Trott

Trott commented May 8, 2019

Copy link
Copy Markdown
Member

Now that there's the Windows-specific conditions, can we add a run-only-on-Windows test case or two for the \\ stuff just to make sure it works as expected?

@nodejs-github-bot

nodejs-github-bot commented May 8, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23005/

@cjihrigcjihrig mentioned this pull request May 8, 2019
Closed
3 tasks
@nodejs-github-bot

nodejs-github-bot commented May 8, 2019•
edited by cjihrig
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23008/

EDIT(cjihrig): CI was yellow.

@cjihrig
module: handle relative paths in resolve paths
dac1143
This commit adds support for relative paths in
require.resolve()'s paths option.
PR-URL: nodejs#27598Fixes: nodejs#27583
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@cjihrig
cjihrig merged commit dac1143 into nodejs:masterMay 9, 2019
@cjihrig
cjihrig deleted the 27583 branch May 9, 2019 18:18
@homburghomburg mentioned this pull request May 10, 2019
Closed
targos pushed a commit that referenced this pull request May 10, 2019
@cjihrig@targos
module: handle relative paths in resolve paths
2f512e3
This commit adds support for relative paths in
require.resolve()'s paths option.
PR-URL: #27598Fixes: #27583
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@BridgeARBridgeAR mentioned this pull request May 21, 2019
Merged
4 tasks
@mscdexmscdex mentioned this pull request May 21, 2019
Closed
@deepaldeepal mentioned this pull request Mar 15, 2020
Closed
@tolmaskytolmasky mentioned this pull request Mar 7, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@targostargostargos approved these changes
+1 more reviewer
@danbevdanbevdanbev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Node 12: require.resolve(relativePath, { paths: [ '.' ] }) throws without ./

5 participants

@cjihrig@nodejs-github-bot@Trott@danbev@targos