Uh oh!
There was an error while loading. Please reload this page.
test: remove unneeded --expose-internals - #27608
Closed
Trott wants to merge 1 commit into
Closed
Conversation
test/wpt/test-timers.js does not appear to need the `--expose-internals` flag. Remove it.
nodejs-github-bot
commented
May 8, 2019
Collaborator
nodejs-github-bot
commented
May 8, 2019
Collaborator
joyeecheung
approved these changes
May 8, 2019
BridgeAR
approved these changes
May 8, 2019
ZYSzys
approved these changes
May 8, 2019
richardlau
approved these changes
May 8, 2019
cjihrig
approved these changes
May 8, 2019
trivikr
approved these changes
May 9, 2019
Trott
commented
May 10, 2019
MemberAuthor
Landed in 556de23 |
Trott added a commit
to Trott/io.js
that referenced
this pull request
May 10, 2019
test/wpt/test-timers.js does not appear to need the `--expose-internals` flag. Remove it. PR-URL: nodejs#27608 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit
that referenced
this pull request
May 11, 2019
test/wpt/test-timers.js does not appear to need the `--expose-internals` flag. Remove it. PR-URL: #27608 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/wpt/test-timers.js does not appear to need the
--expose-internalsflag. Remove it.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes