Uh oh!
There was an error while loading. Please reload this page.
child_process: refactor stdioStringToArray function - #27657
Closed
zero1five wants to merge 1 commit into
Closed
Conversation
zero1fiveforce-pushed
the
refactor/child-process
branch
from
May 12, 2019 13:53
fd4a945 to
5265c3dCompare
BridgeAR
left a comment
Member
There was a problem hiding this comment.
If I'm not mistaken this will change the internal stdio type in case of inherit to fd. This might not change anything because the fd itself set the same but I wanted to point this out.
jasnell
approved these changes
May 12, 2019
BridgeAR
commented
May 13, 2019
Member
@nodejs/child_process PTAL at #27657 (review) |
zero1five
commented
May 13, 2019
ContributorAuthor
@BridgeAR Ah... i see. It is indeed described in the documentation that you can use |
BridgeAR
approved these changes
May 13, 2019
nodejs-github-bot
commented
May 13, 2019
Collaborator
nodejs-github-bot
commented
May 14, 2019
Collaborator
Trott
approved these changes
May 14, 2019
Contributor
Re-build of failing node-test-commit-windows-fanned (✔️) |
zero1fiveforce-pushed
the
refactor/child-process
branch
from
May 15, 2019 17:07
5265c3d to
f78ff1eComparereduce the function in both files to one.
zero1fiveforce-pushed
the
refactor/child-process
branch
from
May 15, 2019 17:24
f78ff1e to
ccece4eComparedanbev
commented
May 16, 2019
Contributor
Landed in 9f99d4e. |
pullBot
pushed a commit
to shakir-abdo/node
that referenced
this pull request
May 16, 2019
reduce the function in both files to one. PR-URL: nodejs#27657 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit
that referenced
this pull request
May 17, 2019
reduce the function in both files to one. PR-URL: #27657 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reduce the function in both files to one.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes