Skip to content

http: do not default to chunked encoding for TRACE - #27673

Closed
lpinca wants to merge 1 commit into
nodejs:masterfrom
lpinca:gh-25783
Closed

http: do not default to chunked encoding for TRACE#27673
lpinca wants to merge 1 commit into
nodejs:masterfrom
lpinca:gh-25783

Conversation

@lpinca

@lpincalpinca commented May 13, 2019

Copy link
Copy Markdown
Member

Fixes: #25783

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented May 13, 2019

Copy link
Copy Markdown
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3502

@nodejs-github-botnodejs-github-bot added the http Issues or PRs related to the http subsystem. label May 13, 2019
@BridgeAR

This comment has been minimized.

Sign in to view
@lpinca

lpinca commented May 13, 2019

Copy link
Copy Markdown
MemberAuthor

There is a test, PTAL as I removed the this._hasBody = false; change from eb775c1.

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 14, 2019
@nodejs-github-bot

nodejs-github-bot commented May 14, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23121/

@danbev

danbev commented May 16, 2019

Copy link
Copy Markdown
Contributor

Re-build of failing node-test-commit-linux

@nodejs-github-bot

nodejs-github-bot commented May 19, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23192/

@lpinca

lpinca commented May 19, 2019

Copy link
Copy Markdown
MemberAuthor

@nodejs/platform-aix can you please take a look?

@miladfarca

miladfarca commented May 19, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor
01:23:40 Also: hudson.remoting.Channel$CallSiteStackTrace: Remote call to JNLP4-connect connection from power8-aix-nodejs4.osuosl.org/

Seems like the Jenkins job crashed. Could you try rerunning the tests.

@nodejs-github-bot

nodejs-github-bot commented May 19, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23204/

@lpinca

lpinca commented May 19, 2019

Copy link
Copy Markdown
MemberAuthor

It seems all recent CI runs are failing due to that. @nodejs/build

@nodejs-github-bot

nodejs-github-bot commented May 19, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23213/

@addaleax

addaleax commented May 19, 2019

Copy link
Copy Markdown
Member

Landed in 4fc0238

addaleax pushed a commit that referenced this pull request May 19, 2019
@lpinca@addaleax
http: do not default to chunked encoding for TRACE
4fc0238
Fixes: #25783
PR-URL: #27673
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@lpinca
lpinca deleted the gh-25783 branch May 20, 2019 05:19
targos pushed a commit that referenced this pull request May 20, 2019
@lpinca@targos
http: do not default to chunked encoding for TRACE
bfb9356
Fixes: #25783
PR-URL: #27673
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeARBridgeAR mentioned this pull request May 21, 2019
Merged
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@cjihrigcjihrigcjihrig approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@ZYSzysZYSzysZYSzys approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.httpIssues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TRACE shouldn't default to chunked encoding

10 participants

@lpinca@nodejs-github-bot@BridgeAR@danbev@miladfarca@addaleax@jasnell@Trott@cjihrig@ZYSzys