[12.x] http, http2: flag for overriding server timeout

[ofrobots]

Make it possible to override the default http server timeout. Ideally
there should be no server timeout - as done on the master branch. This
is a non-breaking way to enable platform providers to override the
value.

Ref: #27558
Ref: #27556

This is a semver-minor alternative to #27558 suitable for backporting to 8.x, 10.x and 12.x.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[nodejs-github-bot]

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3523

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/23122/

[MylesBorins]

LGTM

a couple of doc nits

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/23178/

[ofrobots]

@nodejs/lts this is good to squash and land. Let me know if anything else is needed from my side. Once this lands, I can prepare PRs for 10.x and 8.x as well.

[BridgeAR]

LGTM % comments.

[ofrobots]

CI-lite after the doc changes: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3588/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/23261/

[ofrobots]

@nodejs/build: the CI lite built something other than this PR. Did I do something wrong, or is it a problem with a CI-lite?

[Trott]

@nodejs/build: the CI lite built something other than this PR. Did I do something wrong, or is it a problem with a CI-lite?

Looks like it built this PR to me, but I may be missing something you're seeing. What makes you say CI-Lite built the wrong thing?

[ofrobots]

@Trott looking at the console output I see:

10:56:46 Fetching changes from the remote Git repository
10:56:46 > git rev-parse --is-inside-work-tree # timeout=10
10:56:46 > git config remote.origin.url https://github.com/nodejs/node.git # timeout=10
10:56:46 Fetching upstream changes from https://github.com/nodejs/node.git
10:56:46 > git --version # timeout=10
10:56:46 > git fetch --tags --force --progress https://github.com/nodejs/node.git +refs/heads/*:refs/remotes/origin/* # timeout=10
10:56:51 Checking out Revision 46d8af5e618554fcac89e4b15bf06f81de36ef54 (refs/remotes/origin/master)
10:56:51 Commit message: "deps: upgrade to libuv 1.29.1"
10:56:51 [Pipeline] }

This shows a commit that landed on master whereas this PR is targeting 12.x. This suggests to me that CI lite might be hard coded to pick up the master branch rather than the PR head?

[ofrobots]

Landed in 588fd0c.

[refack]

Thanks for the heads up.

the CI lite built something other than this PR.

This shows a commit that landed on master whereas this PR is targeting 12.x. This suggests to me that CI lite might be hard coded to pick up the master branch rather than the PR head?

That ref is just used to detect which MAJOR version of node is used (which indeed was wrong), but the tests were run against this PR's ref:
https://ci.nodejs.org/job/node-test-commit-linuxone/13487/
https://ci.nodejs.org/job/node-linter/3531/console

Ref for version detection, fixed:
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3625/console
picked 4f093e8

15:19:00 > git fetch --tags --force --progress https://github.com/nodejs/node.git refs/pull/27704/head:refs/remotes/origin/_jenkins_local_branch # timeout=10
15:19:03 Checking out Revision 4f093e879b110771b586b701ddd2e9438a9e0eb9 (refs/remotes/origin/_jenkins_local_branch)
15:19:04 Commit message: "http, http2: flag for overriding server timeout"
15:19:04 [Pipeline] }
15:19:04 [Pipeline] // stage
15:19:04 [Pipeline] stage
15:19:04 [Pipeline] { (Run tests)
15:19:04 [Pipeline] script
15:19:04 [Pipeline] {
15:19:04 [Pipeline] sh
15:19:03 > git rev-parse refs/remotes/origin/_jenkins_local_branch^{commit} # timeout=10
15:19:03 > git rev-parse refs/remotes/origin/refs/heads/_jenkins_local_branch^{commit} # timeout=10
15:19:03 > git config core.sparsecheckout # timeout=10
15:19:03 > git checkout -f 4f093e879b110771b586b701ddd2e9438a9e0eb9 # timeout=10
15:19:05 + python tools/getnodeversion.py
15:19:05 [Pipeline] echo
15:19:05 Detected node version: 12.3.2
15:19:05 [Pipeline] echo
15:19:05 NODE_MAJOR_VERSION=12