Uh oh!
There was an error while loading. Please reload this page.
tools: remove unneeded dependency files - #27730
Closed
Trott wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
commented
May 16, 2019
Collaborator
The new version of dmn more effectively cleans unneeded dependency files. (Thanks, BridgeAR!) It's now in the udpate-*.sh files but run it manually to get the benefits now (and to have a smaller diff when we update).
Trottforce-pushed
the
clean-unneeded-eslint-files
branch
from
May 16, 2019 09:44
c6e3590 to
ca8f413Comparetargos
approved these changes
May 16, 2019
BridgeAR
commented
May 16, 2019
Member
This overlaps with #27670 ;) |
BridgeAR
approved these changes
May 16, 2019
mihalskiy
approved these changes
May 16, 2019
ZYSzys
approved these changes
May 16, 2019
Trott
commented
May 16, 2019
MemberAuthor
Lite CI should be sufficient since that's the only one that runs the linter. But if you'd prefer a full test suite, either let me know or kick off the full test suite yourself! |
silverwind
commented
May 16, 2019
Contributor
If only |
lpinca
approved these changes
May 16, 2019
Trott
commented
May 19, 2019
MemberAuthor
Landed in 7bdd8d6 |
Trott added a commit
to Trott/io.js
that referenced
this pull request
May 19, 2019
The new version of dmn more effectively cleans unneeded dependency files. (Thanks, BridgeAR!) It's now in the udpate-*.sh files but run it manually to get the benefits now (and to have a smaller diff when we update). PR-URL: nodejs#27730 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit
that referenced
this pull request
May 20, 2019
The new version of dmn more effectively cleans unneeded dependency files. (Thanks, BridgeAR!) It's now in the udpate-*.sh files but run it manually to get the benefits now (and to have a smaller diff when we update). PR-URL: #27730 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new version of dmn more effectively cleans unneeded dependency
files. (Thanks, BridgeAR!) It's now in the udpate-*.sh files but run it
manually to get the benefits now (and to have a smaller diff when we
update).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes