Uh oh!
There was an error while loading. Please reload this page.
build,win: create junction instead of symlink to out\%config% - #27736
Merged
Conversation
nodejs-github-bot
commented
May 16, 2019
Collaborator
nodejs-github-bot
commented
May 16, 2019
Collaborator
2 tasks
refack
commented
May 16, 2019
ContributorAuthor
/CC @nodejs/build-files @nodejs/platform-windows |
richardlau
approved these changes
May 16, 2019
lpinca
reviewed
May 16, 2019
Uh oh!
There was an error while loading. Please reload this page.
nil4
reviewed
May 25, 2019
Uh oh!
There was an error while loading. Please reload this page.
PR-URL: nodejs#27736 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
refackforce-pushed
the
mklink-j-instead-of-d
branch
from
May 25, 2019 18:42
c7df1b7 to
a388f4dComparetargos pushed a commit
that referenced
this pull request
May 28, 2019
PR-URL: #27736 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #27149 (comment)
Create a junction to
out\%config%instead of symlink, because symlinks need elevation or developer mode on Win10.Background: https://blogs.windows.com/buildingapps/2016/12/02/symlinks-windows-10/
H/T @yodurr
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes