Skip to content

doc: add version info for types - #27754

Closed
mhdawson wants to merge 1 commit into
nodejs:masterfrom
mhdawson:napi-doc-again2
Closed

doc: add version info for types#27754
mhdawson wants to merge 1 commit into
nodejs:masterfrom
mhdawson:napi-doc-again2

Conversation

@mhdawson

@mhdawsonmhdawson commented May 17, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Add version info for types in N-API doc.

Fixes: ttps://github.com//issues/27486

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented May 17, 2019

Copy link
Copy Markdown
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3554

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels May 17, 2019
@mhdawson
doc: add version info for types
024875e
Add version info for types in N-API doc.
Fixes: nodejs#27486
BridgeAR
BridgeAR approved these changes May 20, 2019
View reviewed changes

@BridgeARBridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Trott
Trott approved these changes May 20, 2019
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also rubber-stamp LGTM

@Trott

Trott commented May 26, 2019

Copy link
Copy Markdown
Member

Landed in dd6481a

@TrottTrott closed this May 26, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request May 26, 2019
@mhdawson@Trott
doc: add version info for types
dd6481a
Add version info for types in N-API doc.
PR-URL: nodejs#27754Fixes: nodejs#27486
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request May 28, 2019
@mhdawson@targos
doc: add version info for types
85f505c
Add version info for types in N-API doc.
PR-URL: #27754Fixes: #27486
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targostargos mentioned this pull request Jun 3, 2019
Merged
@mhdawson
mhdawson deleted the napi-doc-again2 branch September 30, 2019 13:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.node-apiIssues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mhdawson@nodejs-github-bot@Trott@BridgeAR