Uh oh!
There was an error while loading. Please reload this page.
doc: corrected tlsSocket.getPeerCertificate response type - #27757
Closed
danbeglin wants to merge 1 commit into
Closed
doc: corrected tlsSocket.getPeerCertificate response type#27757danbeglin wants to merge 1 commit into
danbeglin wants to merge 1 commit into
Conversation
Within tls.md, the documentation for the response of tlsSocket.getPeerCertificate() included subjectaltname documented as an array of values. However these values are actually returned as a single string of concatenated values. The documentation has been updated to reflect this. Fixes: nodejs#27721
danbeglin
commented
May 17, 2019
ContributorAuthor
Recreation of https://github.com/nodejs/node/pull/27734 due to misunderstanding of commit rules |
addaleax
approved these changes
May 17, 2019
3 tasks
Trott
approved these changes
May 17, 2019
lpinca
approved these changes
May 18, 2019
cjihrig
approved these changes
May 18, 2019
jasnell
approved these changes
May 18, 2019
BridgeAR
approved these changes
May 20, 2019
danbev
commented
May 21, 2019
Contributor
Landed in 0ca9297. 🎉 |
danbev pushed a commit
that referenced
this pull request
May 21, 2019
Within tls.md, the documentation for the response of tlsSocket.getPeerCertificate() included subjectaltname documented as an array of values. However these values are actually returned as a single string of concatenated values. The documentation has been updated to reflect this. PR-URL: #27757Fixes: #27721 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit
that referenced
this pull request
May 21, 2019
Within tls.md, the documentation for the response of tlsSocket.getPeerCertificate() included subjectaltname documented as an array of values. However these values are actually returned as a single string of concatenated values. The documentation has been updated to reflect this. PR-URL: #27757Fixes: #27721 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Within tls.md, the documentation for the response of
tlsSocket.getPeerCertificate() included subjectaltname
documented as an array of values. However these values are
actually returned as a single string of concatenated values.
The documentation has been updated to reflect this.
Fixes: #27721
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes