Uh oh!
There was an error while loading. Please reload this page.
doc: correct parameter type on 'subprocess.kill([signal])' - #27760
Closed
himself65 wants to merge 1 commit into
Closed
doc: correct parameter type on 'subprocess.kill([signal])'#27760himself65 wants to merge 1 commit into
himself65 wants to merge 1 commit into
Conversation
himself65
commented
May 18, 2019
MemberAuthor
node/lib/internal/child_process.js Lines 461 to 486 in 030fa2e |
cjihrig
approved these changes
May 18, 2019
jasnell
approved these changes
May 18, 2019
lpinca
approved these changes
May 19, 2019
ZYSzys
approved these changes
May 19, 2019
trivikr
approved these changes
May 20, 2019
ZYSzys
commented
May 20, 2019
Member
Landed in 2e5bc80 🎉 |
pullBot
pushed a commit
to tkamenoko/node
that referenced
this pull request
May 20, 2019
PR-URL: nodejs#27760 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR pushed a commit
that referenced
this pull request
May 21, 2019
PR-URL: #27760 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #27750
Checklist