Uh oh!
There was an error while loading. Please reload this page.
tools: refactor .eslintrc.js - #27789
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
If you want to have a consistent style, what about enabling the rule at the top of the file? That way it would be possible to slowly migrate some files.
devsnek
left a comment
There was a problem hiding this comment.
if i remove the _findPath hack eslint still fails for me.
Oops! Something went wrong! :(
ESLint: 5.15.1.
ESLint couldn't find the plugin "eslint-plugin-markdown". This can happen for a couple different reasons:
1. If ESLint is installed globally, then make sure eslint-plugin-markdown is also installed globally. A globally-installed ESLint cannot find a locally-installed plugin.
2. If ESLint is installed locally, then it's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
npm i eslint-plugin-markdown@latest --save-dev
Path to ESLint package: /Users/gus/.npm-global/lib/node_modules/eslint
If you still can't figure out the problem, please stop by https://gitter.im/eslint/eslint to chat with the team.
devsnek
left a comment
There was a problem hiding this comment.
meant to do request changes not approve
Trott
commented
May 23, 2019
@devsnek What are you running to get that error? |
Trott
commented
May 24, 2019
@devsnek Are you running a globally-installed |
Trott
commented
May 24, 2019
Ah, yes, installing Any openness to the idea that perhaps that shouldn't be supported? (I'm unsure myself. I see the benefit of stuff just-working for someone.) |
devsnek
commented
May 24, 2019
I think we should definitely be supporting global eslint because that's how editors run linting. lint-js isn't the only usage. |
Trott
commented
May 24, 2019
OK! I've left out that change and instead added a comment explaining why the monkeypatching is necessary so no one else comes along and tries to undo it. @devsnek PTAL Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3616/ |
* Add a comment explaining the Module._findPath() hacks so that someone else doesn't do what I do and try to remove them because they seem unnecessary for `make lint` and friends. * Add a trailing comma for consistency with the rest of the file.
Trott
commented
May 24, 2019
Fixed a tiny thing in the comment. Running Lite CI again... Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3617/ |
Trott
commented
May 24, 2019
Landed in 5b8df5e |
* Add a comment explaining the Module._findPath() hacks so that someone else doesn't do what I do and try to remove them because they seem unnecessary for `make lint` and friends. * Add a trailing comma for consistency with the rest of the file. PR-URL: nodejs#27789 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
* Add a comment explaining the Module._findPath() hacks so that someone else doesn't do what I do and try to remove them because they seem unnecessary for `make lint` and friends. * Add a trailing comma for consistency with the rest of the file. PR-URL: #27789 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes