Skip to content

n-api: DRY napi_coerce_to_x() API methods - #27796

Closed
bnoordhuis wants to merge 1 commit into
nodejs:masterfrom
bnoordhuis:dry-napi-coerce
Closed

n-api: DRY napi_coerce_to_x() API methods#27796
bnoordhuis wants to merge 1 commit into
nodejs:masterfrom
bnoordhuis:dry-napi-coerce

Conversation

@bnoordhuis

@bnoordhuisbnoordhuis commented May 21, 2019

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-bot

nodejs-github-bot commented May 21, 2019

Copy link
Copy Markdown
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3585

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 21, 2019
@bnoordhuisbnoordhuis added the node-api Issues and PRs related to the Node-API. label May 21, 2019
mhdawson
mhdawson approved these changes May 22, 2019
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot

nodejs-github-bot commented May 23, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23291/

@danbev

danbev commented May 24, 2019

Copy link
Copy Markdown
Contributor

Landed in c56474f.

@danbevdanbev closed this May 24, 2019
danbev pushed a commit that referenced this pull request May 24, 2019
@bnoordhuis@danbev
n-api: DRY napi_coerce_to_x() API methods
c56474f
PR-URL: #27796
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@bnoordhuis
bnoordhuis deleted the dry-napi-coerce branch May 24, 2019 15:25
targos pushed a commit that referenced this pull request May 28, 2019
@bnoordhuis@targos
n-api: DRY napi_coerce_to_x() API methods
2b7ad12
PR-URL: #27796
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Jun 3, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
+1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.node-apiIssues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@bnoordhuis@nodejs-github-bot@danbev@jasnell@lpinca@cjihrig@mhdawson