Uh oh!
There was an error while loading. Please reload this page.
assert: remove unreachable code - #27840
Closed
Trott wants to merge 1 commit into
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
There is only one entry in `kReadableOperator` that ends in `Unequal`. So the value assigned on line 392 can only be truthy if `operator` is `notDeepEqual`. Therefore, the ternary condition on line 394 is always true. Remove the ternary. Coverage reports confirm that the removed code is unused.
This comment has been minimized.
This comment has been minimized.
cjihrig
approved these changes
May 23, 2019
nodejs-github-bot
commented
May 23, 2019
Collaborator
BethGriggs
approved these changes
May 24, 2019
oyyd
approved these changes
May 24, 2019
trivikr
approved these changes
May 24, 2019
Trott
commented
May 25, 2019
MemberAuthor
Landed in 58fc172 |
Trott added a commit
to Trott/io.js
that referenced
this pull request
May 25, 2019
There is only one entry in `kReadableOperator` that ends in `Unequal`. So the value assigned on line 392 can only be truthy if `operator` is `notDeepEqual`. Therefore, the ternary condition on line 394 is always true. Remove the ternary. Coverage reports confirm that the removed code is unused. PR-URL: nodejs#27840 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit
that referenced
this pull request
May 28, 2019
There is only one entry in `kReadableOperator` that ends in `Unequal`. So the value assigned on line 392 can only be truthy if `operator` is `notDeepEqual`. Therefore, the ternary condition on line 394 is always true. Remove the ternary. Coverage reports confirm that the removed code is unused. PR-URL: #27840 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is only one entry in
kReadableOperatorthat ends inUnequal. Sothe value assigned on line 392 can only be truthy if
operatorisnotDeepEqual. Therefore, the ternary condition on line 394 is alwaystrue. Remove the ternary. Coverage reports confirm that the removed code
is unused.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes