Uh oh!
There was an error while loading. Please reload this page.
child_process: move exports to bottom for better code style - #27845
Closed
himself65 wants to merge 1 commit into
Closed
child_process: move exports to bottom for better code style#27845himself65 wants to merge 1 commit into
himself65 wants to merge 1 commit into
Conversation
himself65
marked this pull request as ready for review
May 24, 2019 06:09
mscdex
reviewed
May 24, 2019
Uh oh!
There was an error while loading. Please reload this page.
jasnell
reviewed
May 24, 2019
Uh oh!
There was an error while loading. Please reload this page.
himself65force-pushed
the
27639
branch
2 times, most recently
from
May 25, 2019 03:58
fe39082 to
897ca32Comparetargos
approved these changes
May 25, 2019
nodejs-github-bot
commented
May 25, 2019
Collaborator
Trott
reviewed
May 25, 2019
Uh oh!
There was an error while loading. Please reload this page.
himself65force-pushed
the
27639
branch
2 times, most recently
from
May 25, 2019 17:42
be8b3cb to
6780a11CompareBridgeAR
approved these changes
May 29, 2019
BridgeAR
commented
May 29, 2019
Member
@himself65 it seems like this needs a rebase :) |
himself65
commented
May 29, 2019
MemberAuthor
@BridgeAR thanks. rebased |
Trott
approved these changes
May 30, 2019
This comment has been minimized.
This comment has been minimized.
ZYSzys
approved these changes
May 30, 2019
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
commented
Jun 2, 2019
Collaborator
Trott
commented
Jun 2, 2019
Member
Landed in aa00968 |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Jun 2, 2019
PR-URL: nodejs#27845 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos pushed a commit
that referenced
this pull request
Jun 3, 2019
PR-URL: #27845 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes