add experimental wasi module support on top of wasm modules - #27850

Closed

devsnek wants to merge 1 commit into

nodejs:masterfrom

devsnek:feature/wasi

devsnek commented May 24, 2019•
edited
Loading

Member

@lukewagner @linclark @guybedford @tschneidereit @ofrobots

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

devsnek added experimental esm wasm labels

devsnek force-pushed the feature/wasi branch from 72b76d7 to 5b6e704Compare

May 24, 2019 13:44

nodejs-github-bot commented May 24, 2019•
edited
Loading

Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3612
CI: https://ci.nodejs.org/job/node-test-pull-request/23836/

nodejs-github-bot added the lib / src label

devsnek force-pushed the feature/wasi branch 2 times, most recently from 6cb5900 to 9304df9Compare

May 24, 2019 13:47

devsnek commented May 24, 2019

MemberAuthor

i tried to set up the test/wasi directory but the test runner isn't recognizing test/wasi/test.js as a test file @nodejs/testing

devsnek commented

View reviewed changes

test/wasi/test.js Outdated

devsnek force-pushed the feature/wasi branch from 9304df9 to 15b7400Compare

May 24, 2019 13:53

MaxGraey reviewed

View reviewed changes

lib/internal/wasi.js Outdated

lukewagner reviewed

View reviewed changes

test/wasi/README.md Outdated

lukewagnerMay 24, 2019

\o/ \o/ Really excited this is testing and running vanilla clang/wasi-sysroot output.

devsnek force-pushed the feature/wasi branch from 15b7400 to ac38308Compare

May 24, 2019 19:48

addaleax reviewed

View reviewed changes

addaleax left a comment

Member

🎉

src/node_options.cc Outdated

devsnek force-pushed the feature/wasi branch from ac38308 to a3e429fCompare

May 28, 2019 21:13

MylesBorins mentioned this pull request

[WIP] esm: basic wasm module env #27815

Closed

ofrobots reviewed

View reviewed changes

ofrobots left a comment

Contributor

Looking great! Thanks for putting this together. I'm experimenting with some 'real world' code that relies on this over at https://github.com/ofrobots/brotli-wasm.

src/node_options.cc Outdated

devsnek force-pushed the feature/wasi branch 2 times, most recently from 4095270 to 8373c5dCompare

May 29, 2019 18:27

devsnek mentioned this pull request

Using node-wasi on the WebAssembly waterfall devsnek/node-wasi#13

Open

cjihrig reviewed

View reviewed changes

test/wasi/test.js Outdated

devsnek force-pushed the feature/wasi branch from cc2f549 to ae37a80Compare

May 30, 2019 22:02

syrusakbary commented May 31, 2019

This is awesome! Great work on the PR 👏

Trott commented Jun 1, 2019

Member

i tried to set up the test/wasi directory but the test runner isn't recognizing test/wasi/test.js as a test file @nodejs/testing

Did this get resolved or is it still a problem?

devsnek commented Jun 1, 2019

MemberAuthor

@Trott still a problem

cjihrig commented Jun 1, 2019

Contributor

@devsnek, rename test/wasi/test.js to test/wasi/test-wasi.js (or something else that begins with test-) and it should work.

devsnek force-pushed the feature/wasi branch from ae37a80 to 90bf7bbCompare

June 2, 2019 15:17

devsnek commented Jun 2, 2019

MemberAuthor

@cjihrig i attempted to add seeking but the native function keeps returning undefined on success instead of the new offset ;(.

if anyone better with napi sees the bug please let me know

cjihrig reviewed

View reviewed changes

src/node_wasi.cc Outdated

Trott force-pushed the master branch from 1ecc406 to 49cf67eCompare

September 17, 2019 16:51

cjihrig mentioned this pull request

wasi: port more wasi libc integration tests nodejs/wasi#16

Merged

cjihrig added a commit to nodejs/wasi that referenced this pull request

wasi: port more wasi libc integration tests

ca8fa3b

This commit ports the following tests from
nodejs/node#27850.
- clock_getres
- getentropy (currently disabled)
- getrusage
- gettimeofday
- notdir
- preopen_populates
- read_file_twice
- stat
- stdin
- write_file
This commit completes the implementations of
fd_filestat_get() and path_filestat_get(), which
are needed for the stat test. This commit also
adds clock_res_get() and partial clock_time_get()
support.

cjihrig added a commit to nodejs/wasi that referenced this pull request

wasi: port more wasi libc integration tests

9720a20

This commit ports the following tests from
nodejs/node#27850.
- clock_getres
- getentropy (currently disabled)
- getrusage
- gettimeofday
- notdir
- preopen_populates
- read_file_twice
- stat
- stdin
- write_file
This commit completes the implementations of
fd_filestat_get() and path_filestat_get(), which
are needed for the stat test. This commit also
adds clock_res_get() and partial clock_time_get()
support.

cjihrig added a commit to nodejs/wasi that referenced this pull request

wasi: port more wasi libc integration tests

c7ccb93

This commit ports the following tests from
nodejs/node#27850.
- clock_getres
- getentropy (currently disabled)
- getrusage
- gettimeofday
- notdir
- preopen_populates
- read_file_twice
- stat
- stdin
- write_file
This commit completes the implementations of
fd_filestat_get() and path_filestat_get(), which
are needed for the stat test. This commit also
adds clock_res_get() and partial clock_time_get()
support.

cjihrig mentioned this pull request

wasi: support following symlinks during path resolution nodejs/wasi#22

Merged

cjihrig added a commit to nodejs/wasi that referenced this pull request

wasi: port more wasi libc integration tests

b1f38bc

This commit ports the following tests from
nodejs/node#27850.
- clock_getres
- getentropy (currently disabled)
- getrusage
- gettimeofday
- notdir
- preopen_populates
- read_file_twice
- stat
- stdin
- write_file
This commit completes the implementations of
fd_filestat_get() and path_filestat_get(), which
are needed for the stat test. This commit also
adds clock_res_get() and partial clock_time_get()
support.

cjihrig added a commit to nodejs/wasi that referenced this pull request

wasi: support resolving symlinks

b0a6bce

This commit adds support for resolving symlinks during
path resolution. This commit also ports all of the remaining
tests from nodejs/node#27850, with
the 'poll' test currently disabled.

cjihrig added a commit to nodejs/wasi that referenced this pull request

wasi: port more wasi libc integration tests

7d36fa2

This commit ports the following tests from
nodejs/node#27850.
- clock_getres
- getentropy (currently disabled)
- getrusage
- gettimeofday
- notdir
- preopen_populates
- read_file_twice
- stat
- stdin
- write_file
This commit completes the implementations of
fd_filestat_get() and path_filestat_get(), which
are needed for the stat test. This commit also
adds clock_res_get() and partial clock_time_get()
support.

cjihrig added a commit to nodejs/wasi that referenced this pull request

wasi: support resolving symlinks

ddcaba5

This commit adds support for resolving symlinks during
path resolution. This commit also ports all of the remaining
tests from nodejs/node#27850, with
the 'poll' test currently disabled.

cjihrig added a commit to nodejs/wasi that referenced this pull request

wasi: port more wasi libc integration tests

5601d51

This commit ports the following tests from
nodejs/node#27850.
- clock_getres
- getentropy (currently disabled)
- getrusage
- gettimeofday
- notdir
- preopen_populates
- read_file_twice
- stat
- stdin
- write_file
This commit completes the implementations of
fd_filestat_get() and path_filestat_get(), which
are needed for the stat test. This commit also
adds clock_res_get() and partial clock_time_get()
support.

cjihrig added a commit to nodejs/wasi that referenced this pull request

wasi: support resolving symlinks

258286c

This commit adds support for resolving symlinks during
path resolution. This commit also ports all of the remaining
tests from nodejs/node#27850, with
the 'poll' test currently disabled.

devsnek closed this

devsnek deleted the feature/wasi branch

October 11, 2019 23:04

cjihrig added a commit to nodejs/wasi that referenced this pull request

wasi: port more wasi libc integration tests

c44eff2

This commit ports the following tests from
nodejs/node#27850.
- clock_getres
- getentropy (currently disabled)
- getrusage
- gettimeofday
- notdir
- preopen_populates
- read_file_twice
- stat
- stdin
- write_file
This commit completes the implementations of
fd_filestat_get() and path_filestat_get(), which
are needed for the stat test. This commit also
adds clock_res_get() and partial clock_time_get()
support.

cjihrig added a commit to nodejs/wasi that referenced this pull request

wasi: support resolving symlinks

4598420

This commit adds support for resolving symlinks during
path resolution. This commit also ports all of the remaining
tests from nodejs/node#27850, with
the 'poll' test currently disabled.

cjihrig added a commit to nodejs/wasi that referenced this pull request

wasi: port more wasi libc integration tests

6b79140

This commit ports the following tests from
nodejs/node#27850.
- clock_getres
- getentropy (currently disabled)
- getrusage
- gettimeofday
- notdir
- preopen_populates
- read_file_twice
- stat
- stdin
- write_file
This commit completes the implementations of
fd_filestat_get() and path_filestat_get(), which
are needed for the stat test. This commit also
adds clock_res_get() and partial clock_time_get()
support.

cjihrig added a commit to nodejs/wasi that referenced this pull request

wasi: support resolving symlinks

6dde317

This commit adds support for resolving symlinks during
path resolution. This commit also ports all of the remaining
tests from nodejs/node#27850, with
the 'poll' test currently disabled.

cjihrig added a commit to nodejs/wasi that referenced this pull request

wasi: port more wasi libc integration tests

2833cb7

This commit ports the following tests from
nodejs/node#27850.
- clock_getres
- getentropy (currently disabled)
- getrusage
- gettimeofday
- notdir
- preopen_populates
- read_file_twice
- stat
- stdin
- write_file
This commit completes the implementations of
fd_filestat_get() and path_filestat_get(), which
are needed for the stat test. This commit also
adds clock_res_get() and partial clock_time_get()
support.

cjihrig added a commit to nodejs/wasi that referenced this pull request

wasi: support resolving symlinks

d59e9e9

This commit adds support for resolving symlinks during
path resolution. This commit also ports all of the remaining
tests from nodejs/node#27850, with
the 'poll' test currently disabled.

cjihrig added a commit to nodejs/wasi that referenced this pull request

wasi: port more wasi libc integration tests

c65f453

This commit ports the following tests from
nodejs/node#27850.
- clock_getres
- getentropy (currently disabled)
- getrusage
- gettimeofday
- notdir
- preopen_populates
- read_file_twice
- stat
- stdin
- write_file
This commit completes the implementations of
fd_filestat_get() and path_filestat_get(), which
are needed for the stat test. This commit also
adds clock_res_get() and partial clock_time_get()
support.

cjihrig added a commit to nodejs/wasi that referenced this pull request

wasi: support resolving symlinks

6041c4d

This commit adds support for resolving symlinks during
path resolution. This commit also ports all of the remaining
tests from nodejs/node#27850, with
the 'poll' test currently disabled.

cjihrig added a commit to nodejs/wasi that referenced this pull request

wasi: port more wasi libc integration tests

5c33f5b

This commit ports the following tests from
nodejs/node#27850.
- clock_getres
- getentropy (currently disabled)
- getrusage
- gettimeofday
- notdir
- preopen_populates
- read_file_twice
- stat
- stdin
- write_file
This commit completes the implementations of
fd_filestat_get() and path_filestat_get(), which
are needed for the stat test. This commit also
adds clock_res_get() and partial clock_time_get()
support.

cjihrig added a commit to nodejs/wasi that referenced this pull request

wasi: support resolving symlinks

36d5c6b

This commit adds support for resolving symlinks during
path resolution. This commit also ports all of the remaining
tests from nodejs/node#27850, with
the 'poll' test currently disabled.

cjihrig added a commit to nodejs/wasi that referenced this pull request

wasi: port more wasi libc integration tests

00e0b59

This commit ports the following tests from
nodejs/node#27850.
- clock_getres
- getentropy (currently disabled)
- getrusage
- gettimeofday
- notdir
- preopen_populates
- read_file_twice
- stat
- stdin
- write_file
This commit completes the implementations of
fd_filestat_get() and path_filestat_get(), which
are needed for the stat test. This commit also
adds clock_res_get() and partial clock_time_get()
support.

cjihrig added a commit to nodejs/wasi that referenced this pull request

wasi: support resolving symlinks

577221b

This commit adds support for resolving symlinks during
path resolution. This commit also ports all of the remaining
tests from nodejs/node#27850, with
the 'poll' test currently disabled.

cjihrig added a commit to nodejs/wasi that referenced this pull request

wasi: port more wasi libc integration tests

ce9deda

This commit ports the following tests from
nodejs/node#27850.
- clock_getres
- getentropy (currently disabled)
- getrusage
- gettimeofday
- notdir
- preopen_populates
- read_file_twice
- stat
- stdin
- write_file
This commit completes the implementations of
fd_filestat_get() and path_filestat_get(), which
are needed for the stat test. This commit also
adds clock_res_get() and partial clock_time_get()
support.

cjihrig added a commit to nodejs/wasi that referenced this pull request

wasi: support resolving symlinks

3e749dc

This commit adds support for resolving symlinks during
path resolution. This commit also ports all of the remaining
tests from nodejs/node#27850, with
the 'poll' test currently disabled.

cjihrig added a commit to nodejs/wasi that referenced this pull request

wasi: port more wasi libc integration tests

1155b22

This commit ports the following tests from
nodejs/node#27850.
- clock_getres
- getentropy (currently disabled)
- getrusage
- gettimeofday
- notdir
- preopen_populates
- read_file_twice
- stat
- stdin
- write_file
This commit completes the implementations of
fd_filestat_get() and path_filestat_get(), which
are needed for the stat test. This commit also
adds clock_res_get() and partial clock_time_get()
support.

cjihrig mentioned this pull request

wasi: introduce initial WASI support #30258

Closed

4 tasks

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

esmexperimentallib / srcsemver-minorwasm