Skip to content

http: fix deferToConnect comments - #27876

Closed
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:fix-defer-to-connect
Closed

http: fix deferToConnect comments#27876
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:fix-defer-to-connect

Conversation

@ronag

@ronagronag commented May 25, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Fixes#27875. Fix description to actual intended and current behaviour.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added http Issues or PRs related to the http subsystem. http2 Issues or PRs related to the http2 subsystem. labels May 25, 2019
@ronag
ronagforce-pushed the fix-defer-to-connect branch from 2f266db to d676912CompareMay 25, 2019 21:27
@Trott

Trott commented May 26, 2019

Copy link
Copy Markdown
Member

Is it non-trivial to write a reliable test for this?

@ronag

ronag commented May 26, 2019

Copy link
Copy Markdown
MemberAuthor

@Trott Before I spend more time on this I'd like to know what the intended behavior here is? writable or connected? I actually think the current behavior of just waiting for writable might be the intended behavior... in which case just the comment needs updating. ping @mcollina

@mcollina

mcollina commented May 26, 2019

Copy link
Copy Markdown
Member

I do not see what is the bug that you are trying to fix. Essentially, I do not know what behavior you would like to change. Neither this PR or #27875 contain an understandable example.

@ronag

ronag commented May 26, 2019

Copy link
Copy Markdown
MemberAuthor

I can't explain it any better than stated in the issue and my previous comment.

@ronag
ronagforce-pushed the fix-defer-to-connect branch from d676912 to f04e167CompareMay 26, 2019 10:39
@ronag

ronag commented May 26, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

I've updated the PR. I believe the current behavior is as intended and it's just the description that needs a slight modification. The method could also possibly have a better name but I dare not modify it...

mcollina
mcollina reviewed May 26, 2019
View reviewed changes
Comment threadlib/_http_client.js Outdated

@mcollinamcollinaMay 26, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to expand this a bit more. What does it mean for the socket to be assigned?

@ronagronagMay 26, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.socket != null?

@mcollinamcollinaMay 26, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but why? Sockets are assigned to a request when they are available in the agent.

@ronagronagMay 26, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expanded to follow the description from https://nodejs.org/api/http.html#http_event_socket

@ronag
ronagforce-pushed the fix-defer-to-connect branch from f04e167 to 2fd58d5CompareMay 26, 2019 15:29
mcollina
mcollina approved these changes May 26, 2019
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good work!

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 27, 2019
@nodejs-github-bot

nodejs-github-bot commented May 27, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23364/

@BridgeARBridgeAR changed the title Fix defer to connecthttp: fix deferToConnect commentsMay 29, 2019
@nodejs-github-bot

nodejs-github-bot commented May 30, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23485/

@nodejs-github-bot

nodejs-github-bot commented May 30, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23492/

@Trott

Trott commented Jun 2, 2019

Copy link
Copy Markdown
Member

Landed in c6f545a

@TrottTrott closed this Jun 2, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Jun 2, 2019
@ronag@Trott
http: fix deferToConnect comments
c6f545a
PR-URL: nodejs#27876
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jun 3, 2019
@ronag@targos
http: fix deferToConnect comments
d948656
PR-URL: #27876
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targostargos mentioned this pull request Jun 3, 2019
Merged
@lpincalpinca mentioned this pull request Jun 23, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@TrottTrottTrott approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.httpIssues or PRs related to the http subsystem.http2Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ClientRequest._deferToConnect doesn't wait until connected

4 participants

@ronag@Trott@mcollina@nodejs-github-bot