Skip to content

doc: reword Experimental stability index - #27879

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:experimental-rewording
May 28, 2019
Merged

doc: reword Experimental stability index#27879
Trott merged 1 commit into
nodejs:masterfrom
Trott:experimental-rewording

Conversation

@Trott

@TrottTrott commented May 26, 2019

Copy link
Copy Markdown
Member

Reword the explanation of the Experimental stability index for brevity
and clarity.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

ChALkeR
ChALkeR reviewed May 26, 2019
View reviewed changes
Comment threaddoc/api/documentation.md Outdated
ChALkeR
ChALkeR approved these changes May 26, 2019
View reviewed changes

@ChALkeRChALkeR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM.

@ChALkeRChALkeR added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels May 26, 2019
@Trott

Trott commented May 26, 2019

Copy link
Copy Markdown
MemberAuthor

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3627/

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 26, 2019
mhdawson
mhdawson approved these changes May 27, 2019
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
doc: reword Experimental stability index
fc7c5b9
Reword the explanation of the Experimental stability index for brevity
and clarity.
PR-URL: nodejs#27879
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@Trott
Trottforce-pushed the experimental-rewording branch from 046bd67 to fc7c5b9CompareMay 28, 2019 05:42
@Trott

Trott commented May 28, 2019

Copy link
Copy Markdown
MemberAuthor

Landed in fc7c5b9

@TrottTrott closed this May 28, 2019
@Trott
Trott merged commit fc7c5b9 into nodejs:masterMay 28, 2019
targos pushed a commit that referenced this pull request May 31, 2019
@Trott@targos
doc: reword Experimental stability index
f621b8f
Reword the explanation of the Experimental stability index for brevity
and clarity.
PR-URL: #27879
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targostargos mentioned this pull request Jun 3, 2019
Merged
@Trott
Trott deleted the experimental-rewording branch January 13, 2022 22:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChALkeRChALkeRChALkeR approved these changes
@targostargostargos approved these changes
+1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.metaIssues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott@ChALkeR@targos@mhdawson