Uh oh!
There was an error while loading. Please reload this page.
timer: call list.start regardless new or not - #2788
Conversation
Call start regardless whether list is new or not to prevent incorrect active_handles count. Fixesnodejs/node-v0.x-archive#25831.
There was a problem hiding this comment.
use strict should be the first line.
thefourtheye
commented
Sep 10, 2015
The |
mscdex
commented
Sep 10, 2015
Is it possible to create a test that doesn't have to compile C++ code (while tests are running)? Maybe utilize |
abbr
commented
Sep 10, 2015
@mscdex, the c++ code is used to expose uv_run to js, not for reporting active handles. |
vkurchatkin
commented
Sep 10, 2015
Why do you need uv_run to test incorrect active handles count? |
Fishrock123
commented
Sep 10, 2015
Please move the tests into |
abbr
commented
Sep 12, 2015
Just realized pr should be applied to master branch. I will close this pr and submit a new one. @mscdex, in my updated test case of the new pr, I found @vkurchatkin , |
Call start regardless whether list is new
or not to prevent incorrect active_handles
count.
Fixesnodejs/node-v0.x-archive#25831.
Ported from pr nodejs/node-v0.x-archive#25832.