Skip to content

test: add test case for checking typeof mgf1Hash - #27892

Closed
Nievl wants to merge 1 commit into
nodejs:masterfrom
Nievl:crypto-keygen-test
Closed

test: add test case for checking typeof mgf1Hash#27892
Nievl wants to merge 1 commit into
nodejs:masterfrom
Nievl:crypto-keygen-test

Conversation

@Nievl

@NievlNievl commented May 26, 2019

Copy link
Copy Markdown
Contributor

add test case to cover uncovered test mgf1Hash param of generateKeyPair,
check typeof

Checklist
  • [ x ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ x ] tests and/or benchmarks are included

@Nievl
test: add test case for checking typeof mgf1Hash
093fcec
add test case to cover uncovered test mgf1Hash param of generateKeyPair,
check typeof
@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label May 26, 2019
@BridgeARBridgeAR added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label May 26, 2019
@nodejs-github-bot

nodejs-github-bot commented May 26, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23342/

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 27, 2019
@ryzokuken

ryzokuken commented May 27, 2019

Copy link
Copy Markdown
Contributor

Thanks everyone! Will land this as soon as 48 hours are up.

@danbev

danbev commented May 29, 2019

Copy link
Copy Markdown
Contributor

Landed in 12f5e0f.

@danbevdanbev closed this May 29, 2019
danbev pushed a commit that referenced this pull request May 29, 2019
@Nievl@danbev
test: add test case for checking typeof mgf1Hash
12f5e0f
add test case to cover uncovered test mgf1Hash param of generateKeyPair,
check typeof
PR-URL: #27892
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit that referenced this pull request May 31, 2019
@Nievl@targos
test: add test case for checking typeof mgf1Hash
67b692b
add test case to cover uncovered test mgf1Hash param of generateKeyPair,
check typeof
PR-URL: #27892
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@targostargos mentioned this pull request Jun 3, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChALkeRChALkeRChALkeR approved these changes
@TrottTrottTrott approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+1 more reviewer
@ryzokukenryzokukenryzokuken approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@Nievl@nodejs-github-bot@ryzokuken@danbev@ChALkeR@Trott@addaleax@cjihrig@gireeshpunathil@BridgeAR