Uh oh!
There was an error while loading. Please reload this page.
test: Covering destroying when worker already disconnected - #27896
Closed
Keroosha wants to merge 1 commit into
Closed
test: Covering destroying when worker already disconnected#27896Keroosha wants to merge 1 commit into
Keroosha wants to merge 1 commit into
Conversation
addaleax
approved these changes
May 26, 2019
cjihrig
approved these changes
May 26, 2019
This test covers 374 line in lib/internal/cluster/master that was uncovered by previous tests
ryzokuken
approved these changes
May 26, 2019
ChALkeR
approved these changes
May 26, 2019
Trott
approved these changes
May 27, 2019
This comment has been minimized.
This comment has been minimized.
gireeshpunathil
approved these changes
May 27, 2019
This comment has been minimized.
This comment has been minimized.
ryzokuken
commented
May 27, 2019
Contributor
Failure: |
BridgeAR
approved these changes
May 29, 2019
trivikr
approved these changes
May 29, 2019
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
commented
May 30, 2019
Collaborator
nodejs-github-bot
commented
May 30, 2019
Collaborator
nodejs-github-bot
commented
Jun 2, 2019
Collaborator
ryzokuken
commented
Jun 2, 2019
Contributor
Landing! |
ryzokuken
commented
Jun 2, 2019
Contributor
Landed in 47ee383 🎉 |
ryzokuken pushed a commit
that referenced
this pull request
Jun 2, 2019
This test covers 374 line in lib/internal/cluster/master that was uncovered by previous tests PR-URL: #27896 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit
that referenced
this pull request
Jun 3, 2019
This test covers 374 line in lib/internal/cluster/master that was uncovered by previous tests PR-URL: #27896 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test covers 374 line in lib/internal/cluster/master that was uncovered by previous tests
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes