Skip to content

test: cover util.inspect on boxed primitive with colors - #27897

Closed
pinguinjkeke wants to merge 1 commit into
nodejs:masterfrom
pinguinjkeke:util-inspect-box-primitive-colors
Closed

test: cover util.inspect on boxed primitive with colors#27897
pinguinjkeke wants to merge 1 commit into
nodejs:masterfrom
pinguinjkeke:util-inspect-box-primitive-colors

Conversation

@pinguinjkeke

@pinguinjkekepinguinjkeke commented May 26, 2019

Copy link
Copy Markdown
Contributor

This PR adds a coverage for util.inspect's colored boxed primitive test-util-inspect.js L868

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label May 26, 2019
@addaleax

This comment has been minimized.

Sign in to view
@ChALkeRChALkeR added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label May 26, 2019
@pinguinjkeke
pinguinjkekeforce-pushed the util-inspect-box-primitive-colors branch from 0d5e08d to c9b4b43CompareMay 26, 2019 14:24
@pinguinjkeke

pinguinjkeke commented May 26, 2019

Copy link
Copy Markdown
ContributorAuthor

@addaleax done

@addaleaxaddaleax changed the title inspector: cover util.inspect on boxed primitive with colorstest: cover util.inspect on boxed primitive with colorsMay 26, 2019
@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 26, 2019
@nodejs-github-bot

nodejs-github-bot commented May 26, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23345/

@nodejs-github-bot

nodejs-github-bot commented May 27, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23381/

@ryzokuken

ryzokuken commented May 27, 2019

Copy link
Copy Markdown
Contributor

Thanks everyone! Will land this as soon as 48 hours are up.

@Trott

Trott commented May 28, 2019

Copy link
Copy Markdown
Member

/ping @BridgeAR

@ryzokuken

ryzokuken commented May 28, 2019

Copy link
Copy Markdown
Contributor

@Trott I'd prefer if @BridgeAR gave his explicit approval, but that said, I believe he personally made this task for the event so it should be fine, really.

@Trott

Trott commented May 28, 2019

Copy link
Copy Markdown
Member

@Trott I'd prefer if @BridgeAR gave his explicit approval, but that said, I believe he personally made this task for the event so it should be fine, really.

Cool. It was just a ping, not a "don't land this until he reviews it". Pinging because I was surprised he hadn't reviewed it yet and figured he'd likely have an opinion. No problem from me with landing it.

@ryzokuken

ryzokuken commented May 29, 2019

Copy link
Copy Markdown
Contributor

@Trott haha, no need to explain, I understood, just wanted to explicitly mention my thoughts. 😇

BridgeAR
BridgeAR reviewed May 29, 2019
View reviewed changes

@BridgeARBridgeAR left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is almost done but it will not yet cover the mentioned line. There is a fast path that is taken to prevent to toLowerCase() from being called if there are no extra properties on the object.
To cover it, add any regular property to the boxed primitive before passing it to util.inspect.

@BridgeAR

BridgeAR commented May 29, 2019

Copy link
Copy Markdown
Member

@Trott thanks, my mailbox got a pile of mentions and I'll go through them later on today. I am just a bit busy that I did not get to it before.

@ryzokuken

ryzokuken commented May 29, 2019

Copy link
Copy Markdown
Contributor

@pinguinjkeke could you please address @BridgeAR's comments above and then we could land this?

@pinguinjkeke

pinguinjkeke commented May 29, 2019

Copy link
Copy Markdown
ContributorAuthor

@BridgeAR I'm trying to hit return ctx.stylize(base, type.toLowerCase()); line.
And my test is hitting it.
If I'll add extra property to the box primitive it will hit return base; line 🤔

@BridgeAR

BridgeAR commented May 29, 2019

Copy link
Copy Markdown
Member

@pinguinjkeke you are right, I did not read the code line correctly!

@ryzokuken

ryzokuken commented May 29, 2019

Copy link
Copy Markdown
Contributor

Landed in c31ac41 🎉

ryzokuken pushed a commit that referenced this pull request May 29, 2019
@pinguinjkeke@ryzokuken
test: cover util.inspect on boxed primitive with colors
c31ac41
PR-URL: #27897
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request May 31, 2019
@pinguinjkeke@targos
test: cover util.inspect on boxed primitive with colors
630cc3a
PR-URL: #27897
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targostargos mentioned this pull request Jun 3, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@ZYSzysZYSzysZYSzys approved these changes
+1 more reviewer
@ryzokukenryzokukenryzokuken approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@pinguinjkeke@addaleax@nodejs-github-bot@ryzokuken@Trott@BridgeAR@cjihrig@gireeshpunathil@ZYSzys@ChALkeR