Uh oh!
There was an error while loading. Please reload this page.
test: switch assertEqual arguments - #27913
Closed
zeckson wants to merge 1 commit into
Closed
Conversation
cjihrig
approved these changes
May 26, 2019
ChALkeR
approved these changes
May 26, 2019
gireeshpunathil
approved these changes
May 27, 2019
nodejs-github-bot
commented
May 27, 2019
Collaborator
Trott
approved these changes
May 27, 2019
nodejs-github-bot
commented
May 27, 2019
Collaborator
ChALkeR
commented
May 27, 2019
Member
Please react with 👍for fast-tracking. |
Trott
commented
May 27, 2019
Member
Landed in 3545a3f. Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
May 27, 2019
PR-URL: nodejs#27913 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit
that referenced
this pull request
May 28, 2019
PR-URL: #27913 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes