Skip to content

meta: create github support file - #27926

Closed
devsnek wants to merge 3 commits into
nodejs:masterfrom
devsnek:support-file
Closed

meta: create github support file#27926
devsnek wants to merge 3 commits into
nodejs:masterfrom
devsnek:support-file

Conversation

@devsnek

Copy link
Copy Markdown
Member

@nodejs/tsc @nodejs/community-committee

Refs: https://help.github.com/en/articles/adding-support-resources-to-your-project

Checklist

@devsnekdevsnek added the meta Issues and PRs related to the general management of the project. label May 27, 2019
@TrottTrott self-assigned this May 27, 2019

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shorthand links won't work without the references at the bottom. I'd inline all of them, though, so that people looking at this in a text editor can understand it easier.

@Trott

Copy link
Copy Markdown
Member

(I'd also recommend replacing the information in README with a link to this file so we don't have to update information in two places.)

@Trott

Trott commented May 27, 2019

Copy link
Copy Markdown
Member

This is what I was going to propose, if it helps: master...Trott:support-file

Refs: help.github.com/en/articles/adding-support-resources-to-your-project
@TrottTrott removed their assignment May 27, 2019
@Trott

Copy link
Copy Markdown
Member

Looks like maybe the lite CI's didn't start automatically. Here's a manually-started Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3629/

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 27, 2019

@keywordnewkeywordnew left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great folks!

My non-blocking comment would be to add what the suggested resources are good for, so unfamiliar people can make better choices without as much guesswork.

For example:

* [Node.js Website](https://nodejs.org/en/)
Good for general information, links to latest changelogs, API docs.

bnb
bnb approved these changes May 27, 2019

@bnbbnb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than these small changes, LGTM.

Comment thread.github/SUPPORT.md
Comment thread.github/SUPPORT.md Outdated
@bnb

bnb commented May 27, 2019

Copy link
Copy Markdown
Contributor

Thank you @devsnek for PRng this in! 💖

Co-Authored-By: Tierney Cyren <accounts@bnb.im>
Comment thread.github/SUPPORT.md Outdated
Co-Authored-By: Rich Trott <rtrott@gmail.com>

@watildewatilde left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@Trott

Copy link
Copy Markdown
Member

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott

Trott commented May 30, 2019

Copy link
Copy Markdown
Member

Landed in f469522

@TrottTrott closed this May 30, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request May 30, 2019
PR-URL: nodejs#27926
Refs: https://help.github.com/en/articles/adding-support-resources-to-your-project
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request May 31, 2019
PR-URL: #27926
Refs: https://help.github.com/en/articles/adding-support-resources-to-your-project
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@devsnek
devsnek deleted the support-file branch June 1, 2019 14:08
@targostargos mentioned this pull request Jun 3, 2019
@richardlaurichardlau mentioned this pull request Jun 3, 2019
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants

@devsnek@Trott@bnb@mcollina@watilde@cjihrig@WaleedAshraf@BridgeAR@keywordnew@trivikr