Uh oh!
There was an error while loading. Please reload this page.
src: export v8.GetHeapCodeAndMetadataStatistics() - #27978
Closed
yvasiyarov wants to merge 1 commit into
Closed
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
yvasiyarovforce-pushed
the
heap_code_and_metadata
branch
from
May 31, 2019 09:34
472d571 to
e8bb983Compareaddaleax
approved these changes
May 31, 2019
addaleax
left a comment
Member
There was a problem hiding this comment.
Looks good code-wise, although I have to admit to not really being sure about what use cases there are
nodejs-github-bot
commented
May 31, 2019
Collaborator
yvasiyarov
commented
May 31, 2019
Author
@addaleax main use case here is monitoring of node.js applications. |
bnoordhuis
approved these changes
Jun 1, 2019
Member
There was a problem hiding this comment.
Typo: kCodeAndMetadataSizeIndex (no n after kCode)
Author
There was a problem hiding this comment.
@bnoordhuis typo fixed. Commit squashed with original commit
joyeecheung
approved these changes
Jun 1, 2019
Export statistic provided by V8 through HeapCodeStatistics class and and GetHeapCodeAndMetadataStatistics function to v8 Node.js module
yvasiyarovforce-pushed
the
heap_code_and_metadata
branch
from
June 4, 2019 12:05
e8bb983 to
07967f6Compareyvasiyarov
commented
Jul 30, 2019
Author
Guys, |
nodejs-github-bot
commented
Jul 30, 2019
Collaborator
joyeecheung
commented
Jul 30, 2019
Member
@yvasiyarov with three approvals it should be ready to land as long as the CI is green (I started one). |
Trott
approved these changes
Jul 30, 2019
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Jul 30, 2019
Export statistic provided by V8 through HeapCodeStatistics class and and GetHeapCodeAndMetadataStatistics function to v8 Node.js module PR-URL: nodejs#27978 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott
commented
Jul 30, 2019
Member
Landed in 21a7c69. Thanks for the contribution! 🎉 |
targos pushed a commit
that referenced
this pull request
Aug 2, 2019
Export statistic provided by V8 through HeapCodeStatistics class and and GetHeapCodeAndMetadataStatistics function to v8 Node.js module PR-URL: #27978 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR added a commit
that referenced
this pull request
Aug 6, 2019
Notable changes: * assert: * Legacy mode deprecation (`DEP0089`) is revoked (Colin Ihrig) #28892 * crypto: * The `outputLength` option is added to `crypto.createHash` (Tobias Nießen) #28805 * The `maxmem` range is increased from 32 to 53 bits (Tobias Nießen) #28799 * n-api: * Added APIs for per-instance state management (Gabriel Schulhof) #28682 * report: * Network interfaces get included in the report (cjihrig) #28911 * src: * `v8.getHeapCodeStatistics()` is now exported (Yuriy Vasiyarov) #27978 PR-URL: #29017
BridgeAR added a commit
to BridgeAR/node
that referenced
this pull request
Aug 6, 2019
Notable changes: * assert: * Legacy mode deprecation (`DEP0089`) is revoked (Colin Ihrig) nodejs#28892 * crypto: * The `outputLength` option is added to `crypto.createHash` (Tobias Nießen) nodejs#28805 * The `maxmem` range is increased from 32 to 53 bits (Tobias Nießen) nodejs#28799 * n-api: * Added APIs for per-instance state management (Gabriel Schulhof) nodejs#28682 * report: * Network interfaces get included in the report (cjihrig) nodejs#28911 * src: * `v8.getHeapCodeStatistics()` is now exported (Yuriy Vasiyarov) nodejs#27978 PR-URL: nodejs#29017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Export statistic provided by V8 through HeapCodeStatistics class and
and GetHeapCodeAndMetadataStatistics function to v8 Node.js module
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes