Uh oh!
There was an error while loading. Please reload this page.
test: finish code coverage for lib/internal/worker.js - #27995
Merged
Conversation
nodejs-github-bot
commented
May 31, 2019
Collaborator
cjihrig
reviewed
May 31, 2019
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
May 31, 2019
Collaborator
lpinca
approved these changes
Jun 1, 2019
Check that the main thread handles unserializable errors in a worker thread as expected. PR-URL: nodejs#27995 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Check that main thread handles an unknown message type from a worker thread as expected. PR-URL: nodejs#27995 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott
commented
Jun 2, 2019
MemberAuthor
Landed in df339bc...e8f3119 |
targos pushed a commit
that referenced
this pull request
Jun 3, 2019
Check that the main thread handles unserializable errors in a worker thread as expected. PR-URL: #27995 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit
that referenced
this pull request
Jun 3, 2019
Check that main thread handles an unknown message type from a worker thread as expected. PR-URL: #27995 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits to complete code coverage for lib/internal/worker.js.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes