Uh oh!
There was an error while loading. Please reload this page.
deps: cherry-pick 6da51b4 from v8's upstream - #2801
Closed
indutny wants to merge 1 commit into
Closed
Conversation
Original commit message:
TypedArray accessor detection: consider entire prototype chain
When looking up a special accessor for known TypedArray fields
("length", "byteLength", "byteOffset"), consider the entire
prototype chain, not only the direct prototype.
This allows subclasses of TypedArrays to benefit from fast
specialized accesses.
Review URL: https://codereview.chromium.org/1313493005
Cr-Commit-Position: refs/heads/master@{nodejs#30678}
Benchmark results:
buffers/buffer-iterate.js size=16386 type=slow method=for n=1000:
./node: 71607 node: 8702.3 ............ 722.85%
Improvement depends on the code, but generally brings us back to the
performance that we had before the v8 update (if not making it
faster).bnoordhuis
commented
Sep 10, 2015
Member
LGTM |
1 similar comment
trevnorris
commented
Sep 10, 2015
Contributor
LGTM |
indutny
commented
Sep 10, 2015
MemberAuthor
@trevnorris@bnoordhuis feel free to land it if you have some availability. |
indutny added a commit
that referenced
this pull request
Sep 10, 2015
Original commit message:
TypedArray accessor detection: consider entire prototype chain
When looking up a special accessor for known TypedArray fields
("length", "byteLength", "byteOffset"), consider the entire
prototype chain, not only the direct prototype.
This allows subclasses of TypedArrays to benefit from fast
specialized accesses.
Review URL: https://codereview.chromium.org/1313493005
Cr-Commit-Position: refs/heads/master@{#30678}
Benchmark results:
buffers/buffer-iterate.js size=16386 type=slow method=for n=1000:
./node: 71607 node: 8702.3 ............ 722.85%
Improvement depends on the code, but generally brings us back to the
performance that we had before the v8 update (if not making it
faster).
Fixes: #2463
PR-URL: #2801
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>bnoordhuis
commented
Sep 10, 2015
Member
Landed in acb6779. |
indutny
commented
Sep 10, 2015
MemberAuthor
Thank you, @bnoordhuis ! |
indutny added a commit
that referenced
this pull request
Sep 11, 2015
Original commit message:
TypedArray accessor detection: consider entire prototype chain
When looking up a special accessor for known TypedArray fields
("length", "byteLength", "byteOffset"), consider the entire
prototype chain, not only the direct prototype.
This allows subclasses of TypedArrays to benefit from fast
specialized accesses.
Review URL: https://codereview.chromium.org/1313493005
Cr-Commit-Position: refs/heads/master@{#30678}
Benchmark results:
buffers/buffer-iterate.js size=16386 type=slow method=for n=1000:
./node: 71607 node: 8702.3 ............ 722.85%
Improvement depends on the code, but generally brings us back to the
performance that we had before the v8 update (if not making it
faster).
Fixes: #2463
PR-URL: #2801
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>oleavr added a commit
to frida/v8
that referenced
this pull request
Sep 11, 2015
Cherry-picked from Node.js: commit acb6779c19abf248a4c6d5c3d3389805e7ee8b8d Author: Fedor Indutny <fedor@indutny.com> Date: Thu Sep 10 12:26:50 2015 -0700 deps: cherry-pick 6da51b4 from v8's upstream Original commit message: TypedArray accessor detection: consider entire prototype chain When looking up a special accessor for known TypedArray fields ("length", "byteLength", "byteOffset"), consider the entire prototype chain, not only the direct prototype. This allows subclasses of TypedArrays to benefit from fast specialized accesses. Review URL: https://codereview.chromium.org/1313493005 Cr-Commit-Position: refs/heads/master@{#30678} Benchmark results: buffers/buffer-iterate.js size=16386 type=slow method=for n=1000: ./node: 71607 node: 8702.3 ............ 722.85% Improvement depends on the code, but generally brings us back to the performance that we had before the v8 update (if not making it faster). Fixes: nodejs/node#2463 PR-URL: nodejs/node#2801 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
oleavr added a commit
to frida/v8
that referenced
this pull request
Sep 11, 2015
Cherry-picked from Node.js: commit acb6779c19abf248a4c6d5c3d3389805e7ee8b8d Author: Fedor Indutny <fedor@indutny.com> Date: Thu Sep 10 12:26:50 2015 -0700 deps: cherry-pick 6da51b4 from v8's upstream Original commit message: TypedArray accessor detection: consider entire prototype chain When looking up a special accessor for known TypedArray fields ("length", "byteLength", "byteOffset"), consider the entire prototype chain, not only the direct prototype. This allows subclasses of TypedArrays to benefit from fast specialized accesses. Review URL: https://codereview.chromium.org/1313493005 Cr-Commit-Position: refs/heads/master@{#30678} Benchmark results: buffers/buffer-iterate.js size=16386 type=slow method=for n=1000: ./node: 71607 node: 8702.3 ............ 722.85% Improvement depends on the code, but generally brings us back to the performance that we had before the v8 update (if not making it faster). Fixes: nodejs/node#2463 PR-URL: nodejs/node#2801 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
oleavr added a commit
to frida/v8
that referenced
this pull request
Sep 12, 2015
Cherry-picked from Node.js: commit acb6779c19abf248a4c6d5c3d3389805e7ee8b8d Author: Fedor Indutny <fedor@indutny.com> Date: Thu Sep 10 12:26:50 2015 -0700 deps: cherry-pick 6da51b4 from v8's upstream Original commit message: TypedArray accessor detection: consider entire prototype chain When looking up a special accessor for known TypedArray fields ("length", "byteLength", "byteOffset"), consider the entire prototype chain, not only the direct prototype. This allows subclasses of TypedArrays to benefit from fast specialized accesses. Review URL: https://codereview.chromium.org/1313493005 Cr-Commit-Position: refs/heads/master@{#30678} Benchmark results: buffers/buffer-iterate.js size=16386 type=slow method=for n=1000: ./node: 71607 node: 8702.3 ............ 722.85% Improvement depends on the code, but generally brings us back to the performance that we had before the v8 update (if not making it faster). Fixes: nodejs/node#2463 PR-URL: nodejs/node#2801 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
oleavr added a commit
to frida/v8
that referenced
this pull request
Sep 12, 2015
Cherry-picked from Node.js: commit acb6779c19abf248a4c6d5c3d3389805e7ee8b8d Author: Fedor Indutny <fedor@indutny.com> Date: Thu Sep 10 12:26:50 2015 -0700 deps: cherry-pick 6da51b4 from v8's upstream Original commit message: TypedArray accessor detection: consider entire prototype chain When looking up a special accessor for known TypedArray fields ("length", "byteLength", "byteOffset"), consider the entire prototype chain, not only the direct prototype. This allows subclasses of TypedArrays to benefit from fast specialized accesses. Review URL: https://codereview.chromium.org/1313493005 Cr-Commit-Position: refs/heads/master@{#30678} Benchmark results: buffers/buffer-iterate.js size=16386 type=slow method=for n=1000: ./node: 71607 node: 8702.3 ............ 722.85% Improvement depends on the code, but generally brings us back to the performance that we had before the v8 update (if not making it faster). Fixes: nodejs/node#2463 PR-URL: nodejs/node#2801 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
oleavr added a commit
to frida/v8
that referenced
this pull request
Sep 12, 2015
Cherry-picked from Node.js: commit acb6779c19abf248a4c6d5c3d3389805e7ee8b8d Author: Fedor Indutny <fedor@indutny.com> Date: Thu Sep 10 12:26:50 2015 -0700 deps: cherry-pick 6da51b4 from v8's upstream Original commit message: TypedArray accessor detection: consider entire prototype chain When looking up a special accessor for known TypedArray fields ("length", "byteLength", "byteOffset"), consider the entire prototype chain, not only the direct prototype. This allows subclasses of TypedArrays to benefit from fast specialized accesses. Review URL: https://codereview.chromium.org/1313493005 Cr-Commit-Position: refs/heads/master@{#30678} Benchmark results: buffers/buffer-iterate.js size=16386 type=slow method=for n=1000: ./node: 71607 node: 8702.3 ............ 722.85% Improvement depends on the code, but generally brings us back to the performance that we had before the v8 update (if not making it faster). Fixes: nodejs/node#2463 PR-URL: nodejs/node#2801 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
oleavr added a commit
to frida/v8
that referenced
this pull request
Sep 12, 2015
Cherry-picked from Node.js: commit acb6779c19abf248a4c6d5c3d3389805e7ee8b8d Author: Fedor Indutny <fedor@indutny.com> Date: Thu Sep 10 12:26:50 2015 -0700 deps: cherry-pick 6da51b4 from v8's upstream Original commit message: TypedArray accessor detection: consider entire prototype chain When looking up a special accessor for known TypedArray fields ("length", "byteLength", "byteOffset"), consider the entire prototype chain, not only the direct prototype. This allows subclasses of TypedArrays to benefit from fast specialized accesses. Review URL: https://codereview.chromium.org/1313493005 Cr-Commit-Position: refs/heads/master@{#30678} Benchmark results: buffers/buffer-iterate.js size=16386 type=slow method=for n=1000: ./node: 71607 node: 8702.3 ............ 722.85% Improvement depends on the code, but generally brings us back to the performance that we had before the v8 update (if not making it faster). Fixes: nodejs/node#2463 PR-URL: nodejs/node#2801 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
oleavr added a commit
to frida/v8
that referenced
this pull request
Sep 12, 2015
Cherry-picked from Node.js: commit acb6779c19abf248a4c6d5c3d3389805e7ee8b8d Author: Fedor Indutny <fedor@indutny.com> Date: Thu Sep 10 12:26:50 2015 -0700 deps: cherry-pick 6da51b4 from v8's upstream Original commit message: TypedArray accessor detection: consider entire prototype chain When looking up a special accessor for known TypedArray fields ("length", "byteLength", "byteOffset"), consider the entire prototype chain, not only the direct prototype. This allows subclasses of TypedArrays to benefit from fast specialized accesses. Review URL: https://codereview.chromium.org/1313493005 Cr-Commit-Position: refs/heads/master@{#30678} Benchmark results: buffers/buffer-iterate.js size=16386 type=slow method=for n=1000: ./node: 71607 node: 8702.3 ............ 722.85% Improvement depends on the code, but generally brings us back to the performance that we had before the v8 update (if not making it faster). Fixes: nodejs/node#2463 PR-URL: nodejs/node#2801 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
oleavr added a commit
to frida/v8
that referenced
this pull request
Sep 12, 2015
Cherry-picked from Node.js: commit acb6779c19abf248a4c6d5c3d3389805e7ee8b8d Author: Fedor Indutny <fedor@indutny.com> Date: Thu Sep 10 12:26:50 2015 -0700 deps: cherry-pick 6da51b4 from v8's upstream Original commit message: TypedArray accessor detection: consider entire prototype chain When looking up a special accessor for known TypedArray fields ("length", "byteLength", "byteOffset"), consider the entire prototype chain, not only the direct prototype. This allows subclasses of TypedArrays to benefit from fast specialized accesses. Review URL: https://codereview.chromium.org/1313493005 Cr-Commit-Position: refs/heads/master@{#30678} Benchmark results: buffers/buffer-iterate.js size=16386 type=slow method=for n=1000: ./node: 71607 node: 8702.3 ............ 722.85% Improvement depends on the code, but generally brings us back to the performance that we had before the v8 update (if not making it faster). Fixes: nodejs/node#2463 PR-URL: nodejs/node#2801 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
oleavr added a commit
to frida/v8
that referenced
this pull request
Sep 12, 2015
Cherry-picked from Node.js: commit acb6779c19abf248a4c6d5c3d3389805e7ee8b8d Author: Fedor Indutny <fedor@indutny.com> Date: Thu Sep 10 12:26:50 2015 -0700 deps: cherry-pick 6da51b4 from v8's upstream Original commit message: TypedArray accessor detection: consider entire prototype chain When looking up a special accessor for known TypedArray fields ("length", "byteLength", "byteOffset"), consider the entire prototype chain, not only the direct prototype. This allows subclasses of TypedArrays to benefit from fast specialized accesses. Review URL: https://codereview.chromium.org/1313493005 Cr-Commit-Position: refs/heads/master@{#30678} Benchmark results: buffers/buffer-iterate.js size=16386 type=slow method=for n=1000: ./node: 71607 node: 8702.3 ............ 722.85% Improvement depends on the code, but generally brings us back to the performance that we had before the v8 update (if not making it faster). Fixes: nodejs/node#2463 PR-URL: nodejs/node#2801 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
oleavr added a commit
to frida/v8
that referenced
this pull request
Sep 12, 2015
Cherry-picked from Node.js: commit acb6779c19abf248a4c6d5c3d3389805e7ee8b8d Author: Fedor Indutny <fedor@indutny.com> Date: Thu Sep 10 12:26:50 2015 -0700 deps: cherry-pick 6da51b4 from v8's upstream Original commit message: TypedArray accessor detection: consider entire prototype chain When looking up a special accessor for known TypedArray fields ("length", "byteLength", "byteOffset"), consider the entire prototype chain, not only the direct prototype. This allows subclasses of TypedArrays to benefit from fast specialized accesses. Review URL: https://codereview.chromium.org/1313493005 Cr-Commit-Position: refs/heads/master@{#30678} Benchmark results: buffers/buffer-iterate.js size=16386 type=slow method=for n=1000: ./node: 71607 node: 8702.3 ............ 722.85% Improvement depends on the code, but generally brings us back to the performance that we had before the v8 update (if not making it faster). Fixes: nodejs/node#2463 PR-URL: nodejs/node#2801 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins
commented
Nov 16, 2015
Contributor
landed in lts as 6098504 |
oleavr added a commit
to frida/v8
that referenced
this pull request
Dec 26, 2015
Cherry-picked from Node.js: commit acb6779c19abf248a4c6d5c3d3389805e7ee8b8d Author: Fedor Indutny <fedor@indutny.com> Date: Thu Sep 10 12:26:50 2015 -0700 deps: cherry-pick 6da51b4 from v8's upstream Original commit message: TypedArray accessor detection: consider entire prototype chain When looking up a special accessor for known TypedArray fields ("length", "byteLength", "byteOffset"), consider the entire prototype chain, not only the direct prototype. This allows subclasses of TypedArrays to benefit from fast specialized accesses. Review URL: https://codereview.chromium.org/1313493005 Cr-Commit-Position: refs/heads/master@{#30678} Benchmark results: buffers/buffer-iterate.js size=16386 type=slow method=for n=1000: ./node: 71607 node: 8702.3 ............ 722.85% Improvement depends on the code, but generally brings us back to the performance that we had before the v8 update (if not making it faster). Fixes: nodejs/node#2463 PR-URL: nodejs/node#2801 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
oleavr added a commit
to frida/v8
that referenced
this pull request
Aug 11, 2016
Cherry-picked from Node.js: commit acb6779c19abf248a4c6d5c3d3389805e7ee8b8d Author: Fedor Indutny <fedor@indutny.com> Date: Thu Sep 10 12:26:50 2015 -0700 deps: cherry-pick 6da51b4 from v8's upstream Original commit message: TypedArray accessor detection: consider entire prototype chain When looking up a special accessor for known TypedArray fields ("length", "byteLength", "byteOffset"), consider the entire prototype chain, not only the direct prototype. This allows subclasses of TypedArrays to benefit from fast specialized accesses. Review URL: https://codereview.chromium.org/1313493005 Cr-Commit-Position: refs/heads/master@{#30678} Benchmark results: buffers/buffer-iterate.js size=16386 type=slow method=for n=1000: ./node: 71607 node: 8702.3 ............ 722.85% Improvement depends on the code, but generally brings us back to the performance that we had before the v8 update (if not making it faster). Fixes: nodejs/node#2463 PR-URL: nodejs/node#2801 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Benchmark results:
Improvement depends on the code, but generally brings us back to the
performance that we had before the v8 update (if not making it
faster).
This should be backported to 4.0.
cc @nodejs/v8 @rvagg@bnoordhuis@trevnorris