Uh oh!
There was an error while loading. Please reload this page.
src: handle exceptions from ToDetailString() - #28019
Closed
addaleax wants to merge 1 commit into
Closed
Conversation
These methods may fail if execution is terminating.
Trott
approved these changes
Jun 2, 2019
Trott
left a comment
Member
There was a problem hiding this comment.
LGTM. I imagine this would be pretty difficult to test reliably, or maybe even at all?
addaleax
commented
Jun 2, 2019
MemberAuthor
@Trott Yes – it’s not possible to test this reliably, and the race condition window is rather small. |
nodejs-github-bot
commented
Jun 2, 2019
Collaborator
targos
approved these changes
Jun 2, 2019
bnoordhuis
approved these changes
Jun 2, 2019
cjihrig
approved these changes
Jun 2, 2019
BridgeAR
approved these changes
Jun 4, 2019
nodejs-github-bot
commented
Jun 9, 2019
Collaborator
addaleax
commented
Jun 9, 2019
MemberAuthor
Landed in 626f243 |
addaleax added a commit
that referenced
this pull request
Jun 9, 2019
These methods may fail if execution is terminating. PR-URL: #28019 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit
that referenced
this pull request
Jun 17, 2019
These methods may fail if execution is terminating. PR-URL: #28019 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These methods may fail if execution is terminating.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes