Skip to content

worker: use DataCloneError for unknown native objects - #28025

Closed
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:message-native-datacloneerror
Closed

worker: use DataCloneError for unknown native objects#28025
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:message-native-datacloneerror

Conversation

@addaleax

@addaleaxaddaleax commented Jun 2, 2019

Copy link
Copy Markdown
Member

This aligns the behaviour better with the web.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@addaleax
worker: use DataCloneError for unknown native objects
d2e9c52
This aligns the behaviour better with the web.
@addaleaxaddaleax added c++ Issues and PRs that require attention from people who are familiar with C++. worker Issues and PRs related to Worker support. labels Jun 2, 2019
targos
targos approved these changes Jun 2, 2019
View reviewed changes
Comment threadsrc/env.h
@nodejs-github-bot

nodejs-github-bot commented Jun 2, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23567/

joyeecheung
joyeecheung approved these changes Jun 2, 2019
View reviewed changes
Comment threadtest/parallel/test-worker-message-port-transfer-native.js Outdated
@nodejs-github-bot

nodejs-github-bot commented Jun 4, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23612/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 4, 2019
@nodejs-github-bot

nodejs-github-bot commented Jun 9, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23732/

@addaleax

addaleax commented Jun 10, 2019

Copy link
Copy Markdown
MemberAuthor

Landed in 7bd2a3f

@addaleax
addaleax deleted the message-native-datacloneerror branch June 10, 2019 13:38
addaleax added a commit that referenced this pull request Jun 10, 2019
@addaleax
worker: use DataCloneError for unknown native objects
7bd2a3f
This aligns the behaviour better with the web.
PR-URL: #28025
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
@addaleax@BridgeAR
worker: use DataCloneError for unknown native objects
d7641d8
This aligns the behaviour better with the web.
PR-URL: #28025
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
@BridgeARBridgeAR mentioned this pull request Jun 17, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targostargostargos approved these changes
@TrottTrottTrott approved these changes
@cjihrigcjihrigcjihrig approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
+1 more reviewer
@TimothyGuTimothyGuTimothyGu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.workerIssues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@addaleax@nodejs-github-bot@Trott@TimothyGu@targos@cjihrig@joyeecheung@BridgeAR