Uh oh!
There was an error while loading. Please reload this page.
doc: remove "strongly recommended" as hedging in fs.md - #28028
Closed
Trott wants to merge 1 commit into
Closed
Conversation
targos
approved these changes
Jun 2, 2019
Trott
commented
Jun 2, 2019
MemberAuthor
cjihrig
approved these changes
Jun 2, 2019
trivikr
approved these changes
Jun 3, 2019
BridgeAR
approved these changes
Jun 4, 2019
ZYSzys
commented
Jun 5, 2019
Member
Landed in 2a2005c. |
BridgeAR pushed a commit
that referenced
this pull request
Jun 17, 2019
PR-URL: #28028 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes