Uh oh!
There was an error while loading. Please reload this page.
test: increase dgram timeout for armv6 - #2808
Conversation
test-dgram-broadcast-multi-process.js and test-dgram-multicast-multi-process.js were failing on Pi 1 because the test was timing out. Changed static 5000ms timeout to a dynamically determined timeout based on the processor using common.platformTimeout().
Trott
commented
Sep 11, 2015
Oh, and you can see the tests failing in prior CI here: https://ci.nodejs.org/job/node-test-commit-arm/591/ |
silverwind
commented
Sep 11, 2015
If the tests were passing before with 5s, I think doing 35s would be a bit too much. How about something like 2s which would still be 14s on that Pi. |
Trott
commented
Sep 11, 2015
The tests take about 11-13 seconds to run on the arm6 machines, so I'm not so sure 35 seconds is out of line if we're looking to have a timeout large enough that the test won't sometimes be flaky. Each test file has a 60 second timeout (unless that's increased for armv6, but I don't think it is), and for this test on armv6, I'd actually be OK giving it the full 60s before blowing up. |
Trott
commented
Sep 11, 2015
I don't think these tests were ever passing on Raspberry Pi 1 machines. We don't (yet) run these tests on CI. (I had to do modify the |
bnoordhuis
commented
Sep 11, 2015
LGTM FWIW |
Fishrock123
commented
Sep 11, 2015
35s seems a bit much, but, eh. |
silverwind
commented
Sep 11, 2015
@Trott: The 60s test timeout is actually increased to 180s for ARMv6, which might be a bit much actually, but otherwise, this is LGTM, thought a test that takes this long isn't really optimal. |
Trott
commented
Sep 11, 2015
If it makes anyone feel less conflicted, there are dozens of tests already in the suite that runs on CI that take as long or longer on the Raspberry Pi 1 devices than these tests take. Sometimes, they take far longer. I'm all for efforts to try to speed these tests up, of course. |
test-dgram-broadcast-multi-process.js and test-dgram-multicast-multi-process.js were failing on Pi 1 because the test was timing out. Changed static 5000ms timeout to a dynamically determined timeout based on the processor using common.platformTimeout(). PR-URL: #2808 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
silverwind
commented
Sep 12, 2015
Thanks, landed in bcc6d47 (just saw another test failure on this). |
test-dgram-broadcast-multi-process.js and test-dgram-multicast-multi-process.js were failing on Pi 1 because the test was timing out. Changed static 5000ms timeout to a dynamically determined timeout based on the processor using common.platformTimeout(). PR-URL: #2808 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
test-dgram-broadcast-multi-process.js and test-dgram-multicast-multi-process.js were failing on Pi 1 because the test was timing out. Changed static 5000ms timeout to a dynamically determined timeout based on the processor using common.platformTimeout(). PR-URL: #2808 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
test-dgram-broadcast-multi-process.js and
test-dgram-multicast-multi-process.js were failing on Pi 1 because the
test was timing out. Changed static 5000ms timeout to a dynamically
determined timeout based on the processor using
common.platformTimeout().
These tests aren't (yet) currently run on CI because they are in
test/internet. But I altered the Makefile and had them run at https://ci.nodejs.org/job/node-test-commit-arm/593/