Uh oh!
There was an error while loading. Please reload this page.
test: set LC_ALL to known good value - #28096
Closed
bnoordhuis wants to merge 1 commit into
Closed
Conversation
Set the locale to a known good value because it affects ICU's date string formatting. Setting LC_ALL needs to happen before the first call to `icu::Locale::getDefault()` because ICU caches the result. Fixes: nodejs#27856
nodejs-github-bot
commented
Jun 6, 2019
Collaborator
Sadly, an error occurred when I tried to trigger a build. :( |
nodejs-github-bot
commented
Jun 6, 2019
Collaborator
cjihrig
approved these changes
Jun 6, 2019
danbev
approved these changes
Jun 7, 2019
jasnell
approved these changes
Jun 10, 2019
Trott
approved these changes
Jun 10, 2019
vdeturckheim
approved these changes
Jun 21, 2019
nodejs-github-bot
commented
Jun 25, 2019
Collaborator
Trott
commented
Jun 25, 2019
Member
Landed in 2bb93e1 |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Jun 25, 2019
Set the locale to a known good value because it affects ICU's date string formatting. Setting LC_ALL needs to happen before the first call to `icu::Locale::getDefault()` because ICU caches the result. Fixes: nodejs#27856 PR-URL: nodejs#28096 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
targos
commented
Jul 2, 2019
Member
Depends on #20026 (semver-major) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the locale to a known good value because it affects ICU's date
string formatting. Setting LC_ALL needs to happen before the first
call to
icu::Locale::getDefault()because ICU caches the result.Fixes: #27856