Uh oh!
There was an error while loading. Please reload this page.
doc: edit reason-for-deprecation text - #28098
Merged
Merged
Conversation
nodejs-github-bot
commented
Jun 6, 2019
Collaborator
Sadly, an error occurred when I tried to trigger a build. :( |
Trott
commented
Jun 6, 2019
MemberAuthor
cjihrig
approved these changes
Jun 6, 2019
trivikr
approved these changes
Jun 6, 2019
2 tasks
antsmartian
approved these changes
Jun 7, 2019
It's not clear (to me, at least) how describing an API as "considered to be unsafe" differs from describing it as simply "unsafe". Use the shorter, latter wording. PR-URL: nodejs#28098 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Trott
commented
Jun 9, 2019
MemberAuthor
Landed in 5694171 |
BridgeAR pushed a commit
that referenced
this pull request
Jun 17, 2019
It's not clear (to me, at least) how describing an API as "considered to be unsafe" differs from describing it as simply "unsafe". Use the shorter, latter wording. PR-URL: #28098 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not clear (to me, at least) how describing an API as "considered
to be unsafe" differs from describing it as simply "unsafe". Use the
shorter, latter wording.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes